Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps-dev): upgrade @types/node to ^18.0.0 to resolve dependency conflict with Vite #1329

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

SEEWON
Copy link

@SEEWON SEEWON commented Sep 24, 2024

Description

This pull request addresses an issue that arose following PR #1328, which migrated the project from React scripts to Vite. During the migration, the @types/node dependency needed to be updated to ensure compatibility with Vite and avoid peer dependency conflicts.

Without updating @types/node to ^18.0.0, local debugging fails with the following error message:

[Error] - Failed to Execute lifecycle deploy due to failed action: cli/runNpmCommand. 
ScriptExecutionError: Unable to execute script action. 
Env output: {"SSL_CRT_FILE":"/path/to/hidden/localhost.crt","SSL_KEY_FILE":"/path/to/hidden/localhost.key"}

This error occurs because Vite and its plugins require @types/node version ^18.0.0 or higher, but the project was still using @types/node 14.x.x, causing a conflict. By upgrading @types/node to ^18.0.0 in both the tab and bot package.json files, this conflict is resolved, and local debugging succeeds.

Changes Made

Updated @types/node to ^18.0.0 in both tab and bot package.json files to resolve conflicts with Vite and its related plugins.

Related Pull Request

PR: #1328 (Migrated project from React scripts to Vite)

@SEEWON
Copy link
Author

SEEWON commented Sep 24, 2024

@microsoft-github-policy-service agree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant