Skip to content

Commit

Permalink
fix: remove well-known storage account key (#1327)
Browse files Browse the repository at this point in the history
  • Loading branch information
yiqing-zhao authored Sep 18, 2024
1 parent 66e478f commit b511fbb
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 6 deletions.
9 changes: 5 additions & 4 deletions large-scale-notification/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -29,10 +29,11 @@ To debug the project, you will need to configure an Azure Service Bus to be used
4. Return to the homepage of your Service Bus namespace and select "+ Queue". Proceed to create a queue with the "Max delivery count" configured to 1.
![Service Bus Queue](./assets/ServiceBusQueue.png)
5. Open **env/.env.local** file, and set the value of `SERVICE_BUS_QUEUE_NAME` with the name of queue you just created.
6. Press "F5" to open a browser window and then select your package to view the large scale notification bot app.
7. Get the endpoint of the trigger. For debug, `<endpoint>` is `http://localhost:3978` by default.
8. Navigate to `http://localhost:3978/api/notification` to activate the sending function. Then, access the `statusQueryGetUri` in the returned JSON object to retrieve the sending status.
9. \[Optional\] Once your app is running locally, you can utilize Azure Storage Explorer to inspect the data in your local storage table. Visit https://learn.microsoft.com/en-us/azure/storage/common/storage-explorer-emulators for more information.
6. Open **teamsapp.local.yml**, and substitue the `${{SECRET_STORAGE_ACCOUNT_KEY}}` with the well-known storage account key listed in the [guide](https://learn.microsoft.com/en-us/azure/storage/common/storage-use-azurite?tabs=visual-studio%2Cblob-storage#well-known-storage-account-and-key).
7. Press "F5" to open a browser window and then select your package to view the large scale notification bot app.
8. Get the endpoint of the trigger. For debug, `<endpoint>` is `http://localhost:3978` by default.
9. Navigate to `http://localhost:3978/api/notification` to activate the sending function. Then, access the `statusQueryGetUri` in the returned JSON object to retrieve the sending status.
10. \[Optional\] Once your app is running locally, you can utilize Azure Storage Explorer to inspect the data in your local storage table. Visit https://learn.microsoft.com/en-us/azure/storage/common/storage-explorer-emulators for more information.

## Execute lifecycle commands

Expand Down
4 changes: 2 additions & 2 deletions large-scale-notification/teamsapp.local.yml
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ deploy:
with:
target: ./env/.env.${{TEAMSFX_ENV}}.user
envs:
SECRET_STORAGE_ACCOUNT_KEY: Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==
SECRET_STORAGE_ACCOUNT_KEY: ${{SECRET_STORAGE_ACCOUNT_KEY}}


# Generate runtime environment variables
Expand All @@ -109,4 +109,4 @@ deploy:
STORAGE_ACCOUNT_NAME: devstoreaccount1
STORAGE_ACCOUNT_URL: http://127.0.0.1:10002/devstoreaccount1
INSTALLATION_TABLE_NAME: localtable
STORAGE_ACCOUNT_KEY: Eby8vdM02xNOcqFlqUwJPLlmEtlCDXJ1OUzFT50uSRZ6IFsuFq2UVErCz4I6tq/K1SZFPTOtr/KBHBeksoGMGw==
STORAGE_ACCOUNT_KEY: ${{SECRET_STORAGE_ACCOUNT_KEY}}

0 comments on commit b511fbb

Please sign in to comment.