Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Excel PowerPoint] (content addins) add support for unified manifest #4668

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

Rick-Kirkham
Copy link
Contributor

@Rick-Kirkham Rick-Kirkham commented Jul 15, 2024

DO NOT MERGE UNTIL PUBLIC PREVIEW OF UNIFIED MANIFEST IN WXP.

Copy link
Contributor

Learn Build status updates of commit 5790b37:

✅ Validation status: passed

File Status Preview URL Details
docs/design/content-add-ins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 69a8f36:

✅ Validation status: passed

File Status Preview URL Details
docs/design/content-add-ins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit b3e33fb:

✅ Validation status: passed

File Status Preview URL Details
docs/design/content-add-ins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

docs/design/content-add-ins.md Outdated Show resolved Hide resolved
docs/design/content-add-ins.md Outdated Show resolved Hide resolved
docs/design/content-add-ins.md Outdated Show resolved Hide resolved
docs/design/content-add-ins.md Outdated Show resolved Hide resolved
docs/design/content-add-ins.md Outdated Show resolved Hide resolved
Co-authored-by: Elizabeth Samuel <[email protected]>
Copy link
Contributor

Learn Build status updates of commit 36b2f18:

✅ Validation status: passed

File Status Preview URL Details
docs/design/content-add-ins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

1. Set the "code.page" object to the full URL of the page that contains the content.
1. Optionally, set the "requestedWidth" and "requestedHeight" properties to a size between 32 and 1000 pixels. If these properties aren't used, the Office application determines the size.
1. Optionally, set the "disableSnapshot" property to `true` to prevent Office from saving a snapshot of the content component with the document.
1. Optionally, add a "requirements.scopes" property to restrict the installability of the content component to only Excel or only PowerPoint. The allowed values are "workbook" and "presentation". (Listing both means the content component is available in both, which is the same as having no "requirements" property at all.)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like requirements property is on this object. If so, will you be updating the requirements property article in this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like requirements property is on this object. If so, will you be updating the requirements property article in this PR?

Good catch. I should do that in the same PR.

Copy link
Contributor

Learn Build status updates of commit 964921f:

✅ Validation status: passed

File Status Preview URL Details
docs/design/content-add-ins.md ✅Succeeded View
docs/develop/requirements-property-unified-manifest.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit 89ec8fe:

✅ Validation status: passed

File Status Preview URL Details
docs/design/content-add-ins.md ✅Succeeded View
docs/develop/requirements-property-unified-manifest.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Copy link
Contributor

Learn Build status updates of commit a295ef8:

✅ Validation status: passed

File Status Preview URL Details
docs/design/content-add-ins.md ✅Succeeded View
docs/develop/requirements-property-unified-manifest.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

@Rick-Kirkham Rick-Kirkham requested a review from jiju-MS July 22, 2024 21:13
Copy link
Contributor

Learn Build status updates of commit 97f4aaf:

✅ Validation status: passed

File Status Preview URL Details
docs/design/content-add-ins.md ✅Succeeded View

For more details, please refer to the build report.

For any questions, please:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants