Pipeline Fix #2526
Merged
Pipeline Fix #2526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jadahiya-MSFT
previously approved these changes
Sep 25, 2024
AE-MS
previously approved these changes
Sep 25, 2024
|
Can you add details on how the pipelines didn't break on your PR but only broke after it was merged? |
noahdarveau-MSFT
dismissed stale reviews from AE-MS and jadahiya-MSFT
via
b7baddf
TrevorJoelHarris
approved these changes
Sep 25, 2024
jadahiya-MSFT
approved these changes
Sep 25, 2024
Ella-ly
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After merging in the Rollup changes, it istreating all .js files in the packages/teams-js directory as esm files. The prepBetaRelease.js is written in commonjs, so it needs to be renamed to prepBetaRelease.cjs to be treated as such and unblock the pipeline since whenever it runs it will try to treat the file as an esm file and wil fail.
This did not break on the PR because the prepBetaRelease step in the pipeline has a condition so that it only runs for pipelines running on the main branch, not PR branches. Since the step was skipped, the file was not run and therefore did not error out.