Add userClickTimeV2 context value. #2522
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request exposes the new field
userClickTimeV2which can be used to properly measured app initialization time since the user clicked on the app. This field must be set by using the monotonic timers API exposed by theperformancefeature of JavaScript asperformance.now() + performance.timeOriginand can be used to measure any necessary elapsed time between click and any other point.Main changes in the PR:
userClickTimeV2in context type objects.Validation
Validation performed:
Ran tests and build everything to validate everything keep working as usual.
Unit Tests added:
No, didn't seem needed as this field is not set by this codebase.
End-to-end tests added:
No
Additional Requirements
Change file added:
Yes