-
Notifications
You must be signed in to change notification settings - Fork 199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unify some of the appid code, improve script tag detection and add validation #2519
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AE-MS
commented
Sep 23, 2024
AE-MS
changed the title
Unify some of the appid code
Unify some of the appid code, improve script tag detection and add validation
Sep 23, 2024
change/@microsoft-teams-js-81b620f2-8af1-4450-89b0-20600bac843e.json
Outdated
Show resolved
Hide resolved
TrevorJoelHarris
previously approved these changes
Sep 23, 2024
erinha
reviewed
Sep 25, 2024
packages/teams-js/test/private/externalAppAuthentication.spec.ts
Outdated
Show resolved
Hide resolved
erinha
approved these changes
Sep 25, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
TrevorJoelHarris
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The codebase currently has some duplication in a few areas:
Main changes in the PR:
AppId
type -- note: the input parameters for appids unfortunately cannot be changed fromstring
toAppId
at this time since that would be a API-breaking change.hasScriptTags
functionValidation
Validation performed:
Unit Tests added:
Yes
End-to-end tests added:
No
Additional Requirements
Change file added:
Yes
Next/remaining steps:
There are still a few places that use the old
validateId
function but that I did not change to useAppId
. This is because the data being validated were not actually an app ids -- they are fields like "title id" and "oauthConfigId". It's not clear why these other ID types were using the app id validation code so I can't tell whether to unify them now. I have questions out to the owners about this and will follow up in a subsequent change.