Update WebStorage to test proper result responses from the host sdk #2463
Conversation
| "expectedTestAppValue": "webStorage is cleared on user log out" | ||
| "expectedTestAppValue": "webStorage is cleared on user log out", | ||
| "hostSdkVersion": { | ||
| "web": "<4.0.2" |
There was a problem hiding this comment.
I think this PR might need to wait for a little bit since Web Host SDK is releasing and I am not sure which version you should exactly to have here.
There was a problem hiding this comment.
sounds good, will wait
I'm not totally sure I understand how this works but does there need to be another restriction on these cases because for the teamsjs version? The behavior of the test app now changes depending on which version of TJS is being used (e.g., the test app from TJS before your change prints a different message). Is this same JSON file used when the tests are run against TJS 2.26? Or does it use the JSON files that were part of 2.26? Refers to: apps/teams-test-app/e2e-test-data/webStorage.json:4 in 1173e5e. [](commit_id = 1173e5e, deletion_comment = False) |
|
I approved this but I left an open question that I don't know the answer to and I'm not sure if it should block this getting merged. |
Description
This PR updates the WebStorage E2E tests to better handle different host SDK versions. We're adding new test cases for webstorage because we have a new flag to test webstorage behavior.
Main changes in the PR:
apps/teams-test-app/e2e-test-data/webStorage.json.isWebStorageClearedOnUserLogOutfunction implementation inapps/teams-test-app/src/components/WebStorageAPIs.tsx.Validation
Validation performed:
Unit Tests added:
No new unit tests were added as this change primarily affects E2E tests.
End-to-end tests added:
Yes, the existing E2E tests for WebStorage have been updated and expanded.
Additional Requirements
Change file added:
No
Related PRs:
N/A
Next/remaining steps:
Screenshots:
N/A