Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update authentication test to include isMicrosoftOwned case in getUser #2425

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexneyman-MSFT
Copy link
Contributor

For more information about how to contribute to this repo, visit this page.

Description

This PR adds a new test case for the getUser API Call specifically for Microsoft-owned apps with host SDK version >3.1.0. This ensures that the getUser functionality works correctly for Microsoft-owned apps in newer host SDK versions.

Main changes in the PR:

  1. Added a new test case in the authentication.json file for getUser API Call with hostSdkVersion > 3.1.0 for Microsoft-owned apps
  2. Maintained existing test parameters and expected results for consistency

Validation

Validation performed:

  1. Ran e2e tests locally

Unit Tests added:

No

End-to-end tests added:

Yes

Additional Requirements

Change file added:

Yes

Related PRs:

N/A

Next/remaining steps:

The feature is complete after this PR.

Screenshots:

N/A

@alexneyman-MSFT alexneyman-MSFT requested a review from a team as a code owner July 25, 2024 13:46
Copy link
Contributor

@AE-MS AE-MS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks okay but it won't pass until the corresponding host SDK change is added to main.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants