Added E2E tests for externalAppCardActionsForCEA APIs

OfficeDev · Sep 27, 2024 · 58b023d · 58b023d
1 parent 5851073
commit 58b023d
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 11 deletions.
diff --git a/apps/teams-test-app/e2e-test-data/externalAppCardActionsForCEA.json b/apps/teams-test-app/e2e-test-data/externalAppCardActionsForCEA.json
@@ -0,0 +1,13 @@
+{
+  "name": "ExternalAppCardActionsForCEA",
+  "version": ">2.18.0",
+  "platform": "Web",
+  "testCases": [
+    {
+      "title": "checkExternalAppCardActionsForCEACapability API Call - Success",
+      "type": "callResponse",
+      "boxSelector": "#box_checkExternalAppCardActionsForCEACapability",
+      "expectedTestAppValue": "External App Card Actions For CEA module is supported"
+    }
+  ]
+}
diff --git a/apps/teams-test-app/src/components/privateApis/ExternalAppCardActionsForCEAAPIs.tsx b/apps/teams-test-app/src/components/privateApis/ExternalAppCardActionsForCEAAPIs.tsx
@@ -14,7 +14,7 @@ const CheckExternalAppCardActionsForCEACapability = (): React.ReactElement =>
       } supported`,
   });
 
-const CECProcessActionSubmit = (): React.ReactElement =>
+const ProcessActionSubmitForCEA = (): React.ReactElement =>
   ApiWithTextInput<{
     appId: AppId;
     conversationId: string;
@@ -27,6 +27,9 @@ const CECProcessActionSubmit = (): React.ReactElement =>
         if (!input.appId) {
           throw new Error('appId is required');
         }
+        if (!input.conversationId) {
+          throw new Error('conversationId is required');
+        }
         if (!input.actionSubmitPayload) {
           throw new Error('actionSubmitPayload is required');
         }
@@ -41,19 +44,20 @@ const CECProcessActionSubmit = (): React.ReactElement =>
       },
     },
     defaultInput: JSON.stringify({
-      appId: 'b7f8c0a0-6c1d-4a9a-9c0a-2c3f1c0a3b0a',
+      appId: new AppId('b7f8c0a0-6c1d-4a9a-9c0a-2c3f1c0a3b0a'),
+      conversationId: 'conversationId',
       actionSubmitPayload: {
         id: 'submitId',
         data: 'data1',
       },
     }),
   });
 
-const CECProcessActionOpenUrl = (): React.ReactElement =>
+const ProcessActionOpenUrlForCEA = (): React.ReactElement =>
   ApiWithTextInput<{
     appId: AppId;
     conversationId: string;
-    url: string;
+    url: URL;
   }>({
     name: 'processActionOpenUrlForCEA',
     title: 'Process Action Open Url For CEA',
@@ -62,6 +66,9 @@ const CECProcessActionOpenUrl = (): React.ReactElement =>
         if (!input.appId) {
           throw new Error('appId is required');
         }
+        if (!input.conversationId) {
+          throw new Error('conversationId is required');
+        }
         if (!input.url) {
           throw new Error('url is required');
         }
@@ -70,22 +77,23 @@ const CECProcessActionOpenUrl = (): React.ReactElement =>
         const result = await externalAppCardActionsForCEA.processActionOpenUrl(
           input.appId,
           input.conversationId,
-          new URL(input.url),
+          input.url,
         );
         return JSON.stringify(result);
       },
     },
     defaultInput: JSON.stringify({
-      appId: 'b7f8c0a0-6c1d-4a9a-9c0a-2c3f1c0a3b0a',
-      url: 'https://www.example.com',
+      appId: new AppId('b7f8c0a0-6c1d-4a9a-9c0a-2c3f1c0a3b0a'),
+      conversationId: 'conversationID',
+      url: new URL('https://www.example.com'),
     }),
   });
 
 const ExternalAppCardActionsForCEAAPIs = (): React.ReactElement => (
   <ModuleWrapper title="External App Card Actions For CEA">
     <CheckExternalAppCardActionsForCEACapability />
-    <CECProcessActionSubmit />
-    <CECProcessActionOpenUrl />
+    <ProcessActionSubmitForCEA />
+    <ProcessActionOpenUrlForCEA />
   </ModuleWrapper>
 );
 

diff --git a/packages/teams-js/src/private/externalAppCardActionsForCEA.ts b/packages/teams-js/src/private/externalAppCardActionsForCEA.ts
@@ -47,7 +47,7 @@ export namespace externalAppCardActionsForCEA {
         ApiName.ExternalAppCardActionsForCEA_ProcessActionOpenUrl,
       ),
       ApiName.ExternalAppCardActionsForCEA_ProcessActionOpenUrl,
-      [appId, url.href, conversationId],
+      [appId, conversationId, url],
     );
     if (error) {
       throw error;
@@ -84,7 +84,9 @@ export namespace externalAppCardActionsForCEA {
         ApiName.ExternalAppCardActionsForCEA_ProcessActionSubmit,
       ),
       ApiName.ExternalAppCardActionsForCEA_ProcessActionSubmit,
-      [appId, conversationId, actionSubmitPayload],
+      appId,
+      conversationId,
+      actionSubmitPayload,
     );
     if (error) {
       throw error;