address comments

OfficeDev · Sep 12, 2024 · 0fedde4 · 0fedde4
1 parent ee5ab0d
commit 0fedde4
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 6 deletions.
diff --git a/apps/teams-test-app/src/pages/TestApp.tsx b/apps/teams-test-app/src/pages/TestApp.tsx
@@ -70,7 +70,6 @@ export const TestApp: React.FC = () => {
   return (
     <>
       <div className="App-container">
-        <ExternalAppCardActionsForCECAPIs />
         <AppAPIs />
         <AppInitializationAPIs />
         <AppInstallDialogAPIs />
@@ -92,6 +91,7 @@ export const TestApp: React.FC = () => {
         <DialogUrlParentCommunicationAPIs childWindowRef={dialogWindowRef} />
         <ExternalAppAuthenticationAPIs />
         <ExternalAppCardActionsAPIs />
+        <ExternalAppCardActionsForCECAPIs />
         <ExternalAppCommandsAPIs />
         <FilesAPIs />
         <FullTrustAPIs />

diff --git a/packages/teams-js/src/private/externalAppCardActionsForCEC.ts b/packages/teams-js/src/private/externalAppCardActionsForCEC.ts
@@ -23,14 +23,15 @@ export namespace externalAppCardActionsForCEC {
       throw errorNotSupportedOnPlatform;
     }
     validateId(appId, new Error('App id is not valid.'));
+    validateId(conversationId, new Error('conversation id is not valid.'));
     return sendMessageToParentAsync<
       [externalAppCardActions.ActionOpenUrlError, externalAppCardActions.ActionOpenUrlType]
     >(
       getApiVersionTag(
         externalAppCardActionsTelemetryVersionNumber,
-        ApiName.ExternalAppCardActions_ProcessActionOpenUrl,
+        ApiName.ExternalAppCardActionsForCEC_ProcessActionOpenUrl,
       ),
-      'externalAppCardActions.cec.processActionOpenUrl',
+      'externalAppCardActionsForCEC.processActionOpenUrl',
       [appId, url.href, conversationId],
     ).then(
       ([error, response]: [externalAppCardActions.ActionOpenUrlError, externalAppCardActions.ActionOpenUrlType]) => {
@@ -54,13 +55,13 @@ export namespace externalAppCardActionsForCEC {
       throw errorNotSupportedOnPlatform;
     }
     validateId(appId, new Error('App id is not valid.'));
-
+    validateId(conversationId, new Error('conversation id is not valid.'));
     return sendMessageToParentAsync<[boolean, externalAppCardActions.ActionSubmitError]>(
       getApiVersionTag(
         externalAppCardActionsTelemetryVersionNumber,
-        ApiName.ExternalAppCardActions_ProcessActionSubmit,
+        ApiName.ExternalAppCardActionsForCEC_ProcessActionSubmit,
       ),
-      'externalAppCardActions.cec.processActionSubmit',
+      'externalAppCardActionsForCEC.processActionSubmit',
       [appId, conversationId, actionSubmitPayload],
     ).then(([wasSuccessful, error]: [boolean, externalAppCardActions.ActionSubmitError]) => {
       if (!wasSuccessful) {