Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[minor] Enable address and parameter address for streaming function #884

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
594 changes: 284 additions & 310 deletions packages/custom-functions-metadata/package-lock.json

Large diffs are not rendered by default.

6 changes: 0 additions & 6 deletions packages/custom-functions-metadata/src/parseTree.ts
Original file line number Diff line number Diff line change
Expand Up @@ -483,12 +483,6 @@ function getOptions(
const errorString = `Since ${errorParam} is present, the last function parameter should be of type CustomFunctions.Invocation :`;
extra.errors.push(logError(errorString, functionPosition));
}

if (isStreamingFunction) {
const functionPosition = getPosition(func);
const errorString = `${errorParam} cannot be used with @streaming.`;
extra.errors.push(logError(errorString, functionPosition));
}
}

if (
Expand Down

This file was deleted.

This file was deleted.

This file was deleted.

This file was deleted.

Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"allowCustomDataForDataTypeAny": true,
"functions": [
{
"description": "Test the new streaming invocation type",
"id": "CUSTOMFUNCTIONSTREAMINGINVOCATIONTEST",
"name": "CUSTOMFUNCTIONSTREAMINGINVOCATIONTEST",
"options": {
"requiresAddress": true,
"stream": true
},
"parameters": [
{
"description": "string",
"name": "x",
"type": "string"
}
],
"result": {
"type": "string"
}
}
]
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
{
"allowCustomDataForDataTypeAny": true,
"functions": [
{
"description": "Test the new streaming invocation type",
"id": "CUSTOMFUNCTIONSTREAMINGINVOCATIONTEST",
"name": "CUSTOMFUNCTIONSTREAMINGINVOCATIONTEST",
"options": {
"stream": true,
"requiresParameterAddresses": true
},
"parameters": [
{
"description": "string",
"name": "x",
"type": "string"
}
],
"result": {
"type": "string"
}
}
]
}