-
Notifications
You must be signed in to change notification settings - Fork 789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Outlook] - NAA sample with IE fallback #860
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The sample looks good. This is mostly a copy edit on the readme. Has someone else tested the IE11 fallback path?
### Create an application registration | ||
|
||
1. Go to the [Azure portal - App registrations](https://go.microsoft.com/fwlink/?linkid=2083908) page to register your app. | ||
1. Sign in with the **_admin_** credentials to your Microsoft 365 tenancy. For example, **[email protected]**. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure how this example helps clarify "admin".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure I understand the comment, but this matches existing Outlook-Add-in-SSO-NAA sample. It doesn't require admin to create the registration, but it does require it to consent to files.read scope.
Samples/auth/Outlook-Add-in-SSO-NAA-IE/src/taskpane/fallback/dialog.html
Outdated
Show resolved
Hide resolved
Co-authored-by: Alex Jerabek <[email protected]>
Co-authored-by: Alex Jerabek <[email protected]>
Co-authored-by: Alex Jerabek <[email protected]>
Co-authored-by: Alex Jerabek <[email protected]>
…ialog.html Co-authored-by: Alex Jerabek <[email protected]>
Co-authored-by: Alex Jerabek <[email protected]>
…fice-Add-in-samples into davech-naa-fallback
Co-authored-by: Alex Jerabek <[email protected]>
…fice-Add-in-samples into davech-naa-fallback
What's in this Pull Request?
This adds a new sample that is similar to Outlook-Add-in-SSO-NAA, but has support for Internet Explorer (IE) fallback. IE fallback sample may not be for every app developer as it adds overhead of supporting multiple auth libraries and polyfills, but can be used as a reference if your add-in must support IE environments.