Commented code to post error as reply to user #168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pawank-MSFT
changed the title
|
Thank you for your PR @Pawank-MSFT.
When I try to use a plugin in a teams channel I get this error, is this what you mean?
|
|
No, That is related to Bot failure if we need to debug in local. |
|
If the code errors. then it's better for the error to be handled and an appropriate message returned to the user instead of suppressing the errors IMO. If the sample isn't suitable for use in a teams channel, then we should look to handle this appropriately without removing feedback to the user entirely. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have seen few of the apps reply with error code as an when something break. To avoid developer from checking in the code in production which will create a spammy behavior for users if app is installed in a channel, we have raise the PR to comment these like which send error messages to user with note.