Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update msgext-northwind-inventory-ts Labs Exercise 3 & 4 #141

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daverupton
Copy link

Updated prompts in Exercise 3 to include the phrase "Northwind Inventory"

Added code change in Exercise 4 and fixed step numbering.

@BobGerman
Copy link
Collaborator

Thanks @daverupton -
For the Ex. 3 changes, it should not be necessary to enter the entire plugin name in prompts; AFAIK it is a partial string match right now, so I don't think those changes should be necessary. Did you find the lab to not work without entering "Northwind Inventory" in its entirety?

The Ex 4 changes look right to me ... thanks!
However I suggest backing out the Ex 3 changes...

@daverupton
Copy link
Author

Thanks @daverupton - For the Ex. 3 changes, it should not be necessary to enter the entire plugin name in prompts; AFAIK it is a partial string match right now, so I don't think those changes should be necessary. Did you find the lab to not work without entering "Northwind Inventory" in its entirety?

The Ex 4 changes look right to me ... thanks! However I suggest backing out the Ex 3 changes...

@BobGerman - The prompts did not work without the additional "inventory" text added. I tried multiple times and all failed. As soon as I added the additional text, they worked.

@daverupton
Copy link
Author

image
image

@garrytrinder
Copy link
Collaborator

@BobGerman are you happy for these changes to be merged?

@garrytrinder
Copy link
Collaborator

Just a note that if we change the instructions in the original Northwind sample, then we should ensure that we make the same changes across the different language versions that we have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants