Handle "no zero transfer" tokens #250
Open
+149
−88
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gzeoneth
requested changes
Sep 23, 2024
yahgwai
reviewed
Oct 8, 2024
| @@ -6,7 +6,7 @@ import "./ERC20Bridge.t.sol"; | |||
| import "../../src/bridge/ERC20Bridge.sol"; | |||
There was a problem hiding this comment.
Should we also have an inbox/bridge test for enqueueing a delayed message
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves BLK-253
looked to find places where zero value custom gas token (or rollup stake token) transfers could occur. these are marked in 2 commits: b69072d and ed56f91
after reviewing the token bridge contracts too, it seems that zero transfers are only maybe possible in the creator if a zero gas price bid is set. This is fine though
mentioning #230, because this PR may be enough of a reason to merge it