Modify way of make test and create a case of test pass

Ocramius · Oct 23, 2014 · 05fd973 · 05fd973
1 parent cd53b44
commit 05fd973
Showing 1 changed file with 26 additions and 5 deletions.
diff --git a/tests/ProxyManagerTest/Generator/Util/ClassGeneratorUtilsTest.php b/tests/ProxyManagerTest/Generator/Util/ClassGeneratorUtilsTest.php
@@ -34,18 +34,39 @@ class ClassGeneratorUtilsTest extends PHPUnit_Framework_TestCase
 {
     public function testCantAddAFinalMethod()
     {
-        $classGenerator = $this->getMock('Zend\\Code\\Generator\\ClassGenerator');
+        $classGenerator  = $this->getMock('Zend\\Code\\Generator\\ClassGenerator');
         $methodGenerator = $this->getMock('Zend\\Code\\Generator\\MethodGenerator');
 
         $methodGenerator
-            ->expects($this->any())
+            ->expects($this->once())
             ->method('getName')
             ->willReturn('foo');
 
+        $classGenerator
+            ->expects($this->never())
+            ->method('addMethodFromGenerator');
+
         $reflection = new ReflectionClass('ProxyManagerTestAsset\\ClassWithFinalMethods');
 
-        $this->assertFalse(
-            ClassGeneratorUtils::addMethodIfNotFinal($reflection, $classGenerator, $methodGenerator)
-        );
+        ClassGeneratorUtils::addMethodIfNotFinal($reflection, $classGenerator, $methodGenerator);
+    }
+
+    public function testCanAddANotFinalMethod()
+    {
+        $classGenerator  = $this->getMock('Zend\\Code\\Generator\\ClassGenerator');
+        $methodGenerator = $this->getMock('Zend\\Code\\Generator\\MethodGenerator');
+
+        $methodGenerator
+            ->expects($this->once())
+            ->method('getName')
+            ->willReturn('publicMethod');
+
+        $classGenerator
+            ->expects($this->once())
+            ->method('addMethodFromGenerator');
+
+        $reflection = new ReflectionClass('ProxyManagerTestAsset\\BaseClass');
+
+        ClassGeneratorUtils::addMethodIfNotFinal($reflection, $classGenerator, $methodGenerator);
     }
 }