Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 33 add helper get xxx method #35

Merged
merged 4 commits into from
May 23, 2024

Conversation

kan-fu
Copy link
Collaborator

@kan-fu kan-fu commented May 9, 2024

Fix #33 DMAS-79712

This PR contains two tasks: add helper method to combine ByDevice and ByLocation, and rename methods to match the api endpoint.

There are still some documentation tasks left for the methods renaming (Readme, Tutorial, Code examples). I will do it after this release when I work on changing the names from camelCase to snake_case (so no duplicate work).

Also no tests were added for the new getXXX methods. Plan to work on it when fixing #31

Added one additional commit for discouraging users from using multiprocessing library. It is out of scope of this PR, but it is a recent issue that caused us some trouble on the server side.

kan-fu added 4 commits May 6, 2024 11:07
…ome public methods for consistency with OpenAPI page
…e renaming, and hide aliases in the API reference.
…ssing libraries

Also removed CI tests on Windows and Mac. GitHub Actions run them in parallel. This is to reduce the workload and speed up the CI.
@eliferguson eliferguson merged commit 4be664d into main May 23, 2024
4 checks passed
@kan-fu kan-fu deleted the issue-33-add-helper-getXXX-method branch May 23, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add helper methods to combine getXXXByLocation and getXXXByDevice into getXXX
2 participants