Issue 9 add docstrings for discovery methods #21
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Renfu-Li
force-pushed
the
docs/discovery-methods
branch
from
3f7d5fc
to
364b214
Compare
Renfu-Li
force-pushed
the
docs/discovery-methods
branch
from
364b214
to
5fa18d1
Compare
|
LGTM. Thanks for your work. |
kan-fu
approved these changes
Dec 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to issue #9 and issue #7
Added numpy-style docstrings for discovery methods in
onc.pyto improve the documentation.All jobs passed after I manually triggered the "Formatting, Linting and Testing" workflow in my forked repo.