Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: bump linter v1.62.2 #3418

Merged
merged 3 commits into from
Dec 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/golangci-lint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
- name: golangci-lint
uses: golangci/golangci-lint-action@v6
with:
version: v1.62.0
version: v1.62.2
- name: notify failure
if: failure() && github.ref == 'refs/heads/main'
env:
Expand Down
5 changes: 1 addition & 4 deletions .golangci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -165,7 +165,6 @@ linters:
- gocyclo
- godot
- godox
- gomnd
- gomoddirectives
- inamedparam
- interfacebloat
Expand All @@ -182,6 +181,4 @@ linters:
- tagliatelle
- varnamelen
- wsl
# Deprecated
- goerr113
- execinquery
- err113
2 changes: 1 addition & 1 deletion .pre-commit/run_linter.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/usr/bin/env bash

VERSION="1.62.0"
VERSION="1.62.2"

if ! command -v golangci-lint &> /dev/null
then
Expand Down
4 changes: 2 additions & 2 deletions cluster/definition.go
Original file line number Diff line number Diff line change
Expand Up @@ -359,15 +359,15 @@ func (d Definition) SetDefinitionHashes() (Definition, error) {
return Definition{}, errors.Wrap(err, "config hash")
}

d.ConfigHash = configHash[:] //nolint: revive // okay to assign to by-value receiver as we return the struct
d.ConfigHash = configHash[:]

// Marshal definition hashDefinition
defHash, err := hashDefinition(d, false)
if err != nil {
return Definition{}, errors.Wrap(err, "definition hashDefinition")
}

d.DefinitionHash = defHash[:] //nolint: revive // okay to assign to by-value receiver as we return the struct
d.DefinitionHash = defHash[:]

return d, nil
}
Expand Down
2 changes: 1 addition & 1 deletion cluster/lock.go
Original file line number Diff line number Diff line change
Expand Up @@ -123,7 +123,7 @@ func (l Lock) SetLockHash() (Lock, error) {
return Lock{}, err
}

l.LockHash = lockHash[:] //nolint: revive // okay to assign to by-value receiver as we return the struct
l.LockHash = lockHash[:]

return l, nil
}
Expand Down
Loading