-
-
Notifications
You must be signed in to change notification settings - Fork 754
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Addition of a new module #643
Conversation
Have you tried to test this module on your local smb system. |
Yes I've tried this on my local machine and even one of the try hackme machine |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sumukhchitloor This module is implemented incorrectly, appears it has been submitted without testing. This modules crashes with error:
AttributeError: module 'smbprotocol' has no attribute 'SMBClient'
SMB requires lots of additional dependencies and configuration which are missing in this PR.
Please always pull the latest version of Nettacker, test your code before submission, include all dependencies, write unit tests and test in docker
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR!
Please note that Nettacker code base has gone through a pretty big refactoring recently.
Would you like to continue working on this PR or I can close it to clean up the PR queue?
Closing this out as inactive, feel free to reopen when it's ready. |
Checklist
Changes proposed in this pull request
Added a new module for smb bruteforce on ports 445 and 139 ,referenced through other modules
Reviewers
@Ali-Razmjoo
@securestep9
Your development environment
Kali GNU/Linux Rolling
2022.4
3.10.9