Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Addition of a new module #643

Closed
wants to merge 2 commits into from
Closed

Conversation

sumukhchitloor
Copy link

@sumukhchitloor sumukhchitloor commented Jan 21, 2023

Checklist

  • I have followed the Contributor Guidelines.
  • The code has been thoroughly tested in my local development environment with flake8 and pylint.
  • The code is Python 3 compatible.
  • The code follows the PEP8 styling guidelines with 4 spaces indentation.
  • This Pull Request relates to only one issue or only one feature
  • I have referenced the corresponding issue number in my commit message
  • I have added the relevant documentation.
  • My branch is up-to-date with the Upstream master branch.

Changes proposed in this pull request

Added a new module for smb bruteforce on ports 445 and 139 ,referenced through other modules

Reviewers

@Ali-Razmjoo
@securestep9

Your development environment

  • OS: Kali GNU/Linux Rolling
  • OS Version: 2022.4
  • Python Version: 3.10.9

@itsdivyanshjain
Copy link
Collaborator

Have you tried to test this module on your local smb system.

@sumukhchitloor
Copy link
Author

sumukhchitloor commented Jan 31, 2023

Yes I've tried this on my local machine and even one of the try hackme machine

@securestep9 securestep9 self-assigned this Feb 18, 2023
@securestep9 securestep9 added the new module pull request with new module(s) label Feb 18, 2023
Copy link
Collaborator

@securestep9 securestep9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumukhchitloor This module is implemented incorrectly, appears it has been submitted without testing. This modules crashes with error:

AttributeError: module 'smbprotocol' has no attribute 'SMBClient'

SMB requires lots of additional dependencies and configuration which are missing in this PR.

Please always pull the latest version of Nettacker, test your code before submission, include all dependencies, write unit tests and test in docker

Copy link
Collaborator

@arkid15r arkid15r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sumukhchitloor

Thanks for your PR!
Please note that Nettacker code base has gone through a pretty big refactoring recently.

Would you like to continue working on this PR or I can close it to clean up the PR queue?

@arkid15r arkid15r marked this pull request as draft September 10, 2024 15:13
@arkid15r
Copy link
Collaborator

Closing this out as inactive, feel free to reopen when it's ready.

@arkid15r arkid15r closed this Sep 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
new module pull request with new module(s)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants