Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace beancount.utils.date_utils.parse_date_liberally with dateutil directly #8

Merged
merged 2 commits into from
Nov 11, 2024

Conversation

Yarikx
Copy link
Contributor

@Yarikx Yarikx commented Nov 11, 2024

The beancount.utils.date_utils.parse_date_liberally was removed from beancount v3 code.
The call was a wrapper for dateutil.parser.parse function anyway, just with the second argument being unwrapped to kwargs.

@Yarikx Yarikx marked this pull request as draft November 11, 2024 10:47
@Yarikx Yarikx marked this pull request as ready for review November 11, 2024 10:51
@coveralls
Copy link

coveralls commented Nov 11, 2024

Pull Request Test Coverage Report for Build 11778586582

Details

  • 8 of 10 (80.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 53.876%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/uabean/importers/tronscan.py 1 2 50.0%
src/uabean/importers/ukrsib_business.py 1 2 50.0%
Totals Coverage Status
Change from base Build 11621757771: 0.0%
Covered Lines: 1096
Relevant Lines: 2006

💛 - Coveralls

@OSadovy
Copy link
Owner

OSadovy commented Nov 11, 2024

@Yarikx Thanks for the contribution!
As we now directly depend on dateutil, let's add it explicitly to the package dependencies in setup.cfg.

@OSadovy OSadovy merged commit cba4100 into OSadovy:master Nov 11, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants