Migrate from Vue2 to Vue3 #42
Open
+4,398
−29,914
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed unused dependencies, everything still works so far.
Everything still works
xmldom is a dependency of osmtogeojson that hasn't been updated yet, the xmldom version had to be updated in the package-lock to get around this, but there are unmerged PRs that should fix this eventually: tyrasd/osmtogeojson#138
It's no longer recommended to use require: https://vite.dev/guide/troubleshooting.html#vite-cjs-node-api-deprecated
|
There are still two warnings in the console, they are from the |
brandovlee
requested changes
Dec 28, 2024
- Override xmldom to fix vulnerability - Update README - Minor formatting - fix SVG warning in Chrome browser
|
ESLint 8.x is deprecated which has lead to some deprecation warnings (no vulnerabilities), but it's a dependency for some libraries that seem like they aren't being maintained any more. I made an issue for this as well to work on in a separate PR since this one is getting very large. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This started as a dependency update, but the majority of vulnerabilities were in dependencies related to Vue CLI. Migrating from Vue CLI to Vite took the vulnerabilities from over 100 down to under 20. This PR will have a LOT of changes.
Vue CLI to Vite
I followed this tutorial for migrating to Vite, at the recommendation of the Vue3 documentation. They also recommend migrating from Vuex to Pinia, which was created as a prototype for Vuex 5, but that should probably be saved for another PR.
Prettier / ESLint
Incompatible Libraries
TODO
Vue2 -> Vue3
@importis deprecated)@usein the vite config, but we needed to update all of the SCSS variables to start with$instead of$--, otherwise they would not be recognized.Merge main after this PR is approved.
Update README with new library docs