Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transitioning from Vue2 to Vue3 #39

Merged
merged 32 commits into from
Dec 30, 2024
Merged

Transitioning from Vue2 to Vue3 #39

merged 32 commits into from
Dec 30, 2024

Conversation

brandovlee
Copy link
Contributor

@brandovlee brandovlee commented Dec 19, 2024

Summary

Most of the dependency update was removing Vue-CLI and it's related dependencies. Switching to Vite not only resolved the majority of the dependencies (100+ ---> 13), but it also led to noticeably faster startup/build times, and overall smoother development.

Notable Changes

  1. Vue CLI ---> Vite
  2. Removed babel, core-js, and sass-loader.
  3. Element UI ---> Element Plus
  4. Vue2 ---> Vue3

To-Do

  • Ensure Prettier and ESLint rules align with each other for cohesive formatting.
  • Replace import with another alternative to align with SASS latest version.
  • Fix image handling in carousel.vue to resolve warnings.

@brandovlee brandovlee requested a review from s-egge December 19, 2024 22:46
package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
@s-egge
Copy link
Member

s-egge commented Dec 23, 2024

After putting some test images into the S3 bucket, they're not showing up at all. It looks like we are going to need to handle passing the images to the carousel differently, we'll probably need to set up a small store, based on this changelog note. This would be a good time to test out Pinia though, the recommended store framework for Vue 3.

@brandovlee brandovlee requested a review from s-egge December 28, 2024 22:34
Copy link
Member

@s-egge s-egge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@s-egge s-egge merged commit 9671732 into master Dec 30, 2024
1 check passed
@s-egge s-egge deleted the update-dependencies branch December 30, 2024 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants