Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add i.saocom and i.sar toolsets #949
base: grass8
Are you sure you want to change the base?
Add i.saocom and i.sar toolsets #949
Changes from 3 commits
745f27c
6d6f61a
d3d1b7c
43a8502
508ce86
17b21ec
a5dea51
30a4eca
11c0383
8cc0212
808e70d
624e557
c97825a
b908143
8db88bf
1de88dd
94ddb1c
5c778ec
8f8bc69
42cca39
2a36fb6
f5d33eb
5c1b994
05257d1
9317ea4
397d673
a9aee3a
52331ba
6d97572
d0d78bc
4e91227
e7a89b4
64e96d8
5114820
62c5269
0442071
bd0e1e0
f4602f6
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need to specify a target location to get the geocoded data? The module will always be run from a certain location, hence that should be the target location, i.e., I'm running i.saocom.geocode from a UTM location, that's where I want the output to be, right? Hence no need for such a parameter.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
check indentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't the default answer be expressed as "plain grass", i.e., hh,hv,vh,vv ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is already imported above
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps rasterio, pandas, geopandas (maybe others too) could be added as lazy loading to allow for module installation even when they are not installed. See for example:
grass-addons/src/imagery/i.landsat/i.landsat.download/i.landsat.download.py
Line 303 in 01aba18