Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i.eodag: Adjust configuration to breaking changes in EODAG 3.0 #1263

Open
wants to merge 2 commits into
base: grass8
Choose a base branch
from

Conversation

ninsbl
Copy link
Member

@ninsbl ninsbl commented Dec 12, 2024

In EODAG 3.0, kwarg for download outputs_prefix has been renamed to output_dir. See: https://eodag.readthedocs.io/en/stable/breaking_changes.html#b3

In consequence, the output parameter of the module is not respected, and downloaded files end up in a local tempdir.

This PR adjust the kwarg name according to the changes in EODAG.

In EODAG 3.0, kwarg for download _outputs_prefix_ has been renamed to _output_dir_. See: https://eodag.readthedocs.io/en/stable/breaking_changes.html#b3 This PR adjust the kwarg name accordingly.
@ninsbl ninsbl added bug Something isn't working Python Related code is in Python labels Dec 12, 2024
@ninsbl ninsbl requested a review from veroandreo December 12, 2024 14:23
@veroandreo
Copy link
Contributor

@HamedElgizery would you mind checking this, please? Looks fine to me, but I cannot test it right now. Thanks! 🙏

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Python Related code is in Python
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants