Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Airocean projection (formerly Dymaxion) #4303

Open
wants to merge 17 commits into
base: master
Choose a base branch
from

Conversation

plouvart
Copy link

@plouvart plouvart commented Nov 1, 2024

  • Closes Add Dymaxion/Fuller Projection #232
  • Tests added
  • Added clear title that can be used to generate release notes
  • Fully documented, including updating docs/source/*.rst for new API

@plouvart plouvart changed the title Add Airocean projection (formerly Dymaxion) #232 Add Airocean projection (formerly Dymaxion) Nov 1, 2024
src/projections/airocean.cpp Outdated Show resolved Hide resolved
src/projections/airocean.cpp Show resolved Hide resolved
@plouvart
Copy link
Author

plouvart commented Nov 1, 2024

Seems like cppcheck is complaining about some unused variable, despite the fact that it is used next line.
Edit: just saw your fix above :)

@rouault rouault added this to the 9.6.0 milestone Nov 1, 2024
@rouault
Copy link
Member

rouault commented Nov 1, 2024

A few typos in the doc reported in https://github.com/OSGeo/PROJ/actions/runs/11632419978/job/32395481110?pr=4303 . For words which are legitimate and must be allowed, you can add them in docs/source/spelling_wordlist.txt

@plouvart
Copy link
Author

plouvart commented Nov 1, 2024

Thanks for the fix for the out of projection domain error

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Dymaxion/Fuller Projection
2 participants