CMake: add a policy_max to cmake_minimum_required(), and remove obsolete cmake_policy() statements #4001
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rouault
force-pushed
the
cmake_cleanup
branch
from
b42c79f to
7a1ea87
Compare
|
With regard to the googletest changes, wouldn't it make more sense to use FetchContent described here? Some of the relevant changes were previously in commits from PR 3997 (but some of these changes were backed out). The method used in PROJ was based on an old version of the guide before FetchContent was available. |
yes probably. I didn't want to change that, but changing cmake_minimum_required(VERSION 3.16) to cmake_minimum_required(VERSION 3.16...3.28) caused warnings in the googletest stuff. And now there's this mysterious error with MacOS build. I'm going to close this PR for now to let other changes slip in before |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.