Facilitate UDA for WSEGVALV item 4 #3684
Conversation
|
I guess this begins to address Issue #3493? If so, that's very welcome. |
I wasn't aware of the issue, but yes - intention is to address exactly this. |
Cool! Please don't hesitate to ask if/when you get to the part concerning representing these values in the restart file. |
Thanks, I definitely need input on that - will reach out next week. |
vkip
force-pushed
the
wsegvalv_uda_item4
branch
from
aff059a to
bf7aa6a
Compare
vkip
force-pushed
the
wsegvalv_uda_item4
branch
from
bf7aa6a to
cadbcda
Compare
| double Valve::conCrossArea() const { | ||
| return m_con_cross_area; | ||
| double Valve::conCrossArea(const std::optional<const ValveUDAEval>& uda_eval_optional) { | ||
| m_con_cross_area_value = uda_eval_optional.has_value() ? | ||
| uda_eval_optional.value().value(m_con_cross_area, m_udq_default) : | ||
| m_con_cross_area.getSI(); |
There was a problem hiding this comment.
Maybe instead of making the member function be non-const we can mark the m_con_cross_area data member be mutable instead? That way we can still call conCrossArea() on a const Valve object and we might not have to provide read/write access to the Valve and segment set objects.
There was a problem hiding this comment.
Ah, that's much better, thanks. Will update.
|
jenkins build this please |
No description provided.