Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parsing WSEGVALV keyword with string failed #3493

Open
hrsut opened this issue Apr 27, 2023 · 6 comments
Open

Parsing WSEGVALV keyword with string failed #3493

hrsut opened this issue Apr 27, 2023 · 6 comments

Comments

@hrsut
Copy link

hrsut commented Apr 27, 2023

Hi
I tried to parse WSEGVALV keyword with a string as follows for example:

WSEGVALV
  WELL_A 2 1.0 FUARE_CC 5* 0.008 /
/

Returning to error:

Internal error: Malformed floating point number 'FUARE_CC'
@GitPaean
Copy link
Member

Hei,

Thanks for reporting, but the forth item should be a Cross-section area, which should be a numerical number.

I think FUARE_CC is a string here. Do you define it is actually a number somewhere?

Sorry if I miss something here.

@hrsut

@bska
Copy link
Member

bska commented Apr 27, 2023

Thanks for reporting, but the fourth item should be a Cross-section area, which should be a numerical number.

I think FUARE_CC is a string here

It is indeed a string, but the initial prefix FU leads me to believe that it is the name of a (field level) user-defined quantity (UDQ). In other words, the model is trying to use this UDQ as a user-defined argument (UDA) in WSEGVALV.

Regrettably, the Flow simulator does not permit UDAs in WSEGVALV at the moment, only in control keywords like WCONPROD and WELTARG. There is at least some amount of work needed to allow UDAs here.

@hrsut
Copy link
Author

hrsut commented Apr 27, 2023

Hi, yes it is correct that this FUAREA_CC is a UDQ defined in the schedule files.
So before it, there is keyword of

UDQ
DEFINE FUAREA_CC 0.005 /
/

I saw a PR on fixing this for WCONPROD few years ago. Hopefully this can be solved as well.

@bska
Copy link
Member

bska commented May 1, 2023

I saw a PR [adding support for UDAs in] WCONPROD few years ago. Hopefully this can be solved as well.

Permitting UDAs in WSEGVALV for calculation purposes is probably fairly straightforward. The biggest part of adding UDAs here, however, is how to represent those UDAs in our restart files. In any case, I have added an item for this to our "feature backlog" for the simulator. We will keep informed of our development in this area.

@hrsut
Copy link
Author

hrsut commented May 9, 2023

thanks ! looking forward for the new development 👍

@bska
Copy link
Member

bska commented Oct 18, 2023

thanks ! looking forward for the new development 👍

I'd like to give an update here. In the latest development sources, we have added preliminary support for for UDAs in item 4 of WSEGVALV. At present we do not have support for restarting simulation runs with those UDAs, but it may nevertheless be of some assistance to you. Unfortunately, this development did not make it into the main development branch in time for the October release, so if you run released versions of the simulator you will have to wait for the H1 2024 release–tentatively scheduled for late April of 2024.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants