- Fix requête sql qui supprimer les liens en double pour un même ID d…

…istant sur les produits
OPEN-DSI · Jul 20, 2021 · 3fc4683 · 3fc4683
1 parent 5d1952b
commit 3fc4683
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 4 deletions.
diff --git a/ChangeLog.md b/ChangeLog.md
@@ -1,5 +1,8 @@
 # ChangeLog
 
+## 4.0.77.0
+- Fix requête sql qui supprimer les liens en double pour un même ID distant sur les produits
+
 ## 4.0.76.0
 - Correction mineure compatibilité V13+ avec la note d'un produit lors de sa creation sur Dolibarr pendant d'une synchro
 

diff --git a/class/data/eCommerceSite.class.php b/class/data/eCommerceSite.class.php
@@ -109,8 +109,10 @@ function cleanDuplicatesRemoteID()
 				$ids[] = $obj->remote_id;
 			}
 		}
-		$sql = "DELETE FROM " . MAIN_DB_PREFIX . "ecommerce_product WHERE remote_id IN (" . implode(',', $ids) . ")";
-		$this->db->query($sql);
+		if (!empty($ids)) {
+			$sql = "DELETE FROM " . MAIN_DB_PREFIX . "ecommerce_product WHERE remote_id IN (" . implode(',', $ids) . ")";
+			$this->db->query($sql);
+		}
 	}
 
     /**

diff --git a/core/modules/modECommerceNg.class.php b/core/modules/modECommerceNg.class.php
@@ -61,7 +61,7 @@ function __construct($db)
 		$this->editor_url = 'http://www.open-dsi.fr';
 
 		// Possible values for version are: 'development', 'experimental', 'dolibarr' or version
-		$this->version = '4.0.76';
+		$this->version = '4.0.77';
 		// Key used in llx_const table to save module status enabled/disabled (where MYMODULE is value of property name of module in uppercase)
 		$this->const_name = 'MAIN_MODULE_'.strtoupper($this->name);
 		// Where to store the module in setup page (0=common,1=interface,2=others,3=very specific)
@@ -217,7 +217,7 @@ function __construct($db)
 		$this->cronjobs = array(
 		//	0=>array('label'=>'AutoSyncEcommerceNg', 'jobtype'=>'method', 'class'=>'ecommerceng/class/business/eCommerceUtils.class.php', 'objectname'=>'eCommerceUtils', 'method'=>'synchAll', 'parameters'=>'100', 'comment'=>'Synchronize all data from eCommerce to Dolibarr. Parameter is max nb of record to do per synchronization run.', 'frequency'=>1, 'unitfrequency'=>86400, 'priority'=>90, 'status'=>0, 'test'=>true),
 			1=>array('label'=>'ECommerceProcessPendingWebHooks', 'jobtype'=>'method', 'class'=>'/ecommerceng/class/business/eCommercePendingWebHook.class.php', 'objectname'=>'eCommercePendingWebHook', 'method'=>'cronProcessPendingWebHooks', 'parameters'=>'', 'comment'=>'Process all pending WebHooks.', 'frequency'=>15, 'unitfrequency'=>60, 'priority'=>90, 'status'=>0, 'test'=>true),
-			2=>array('label'=>'ECommerceCheckWebHooksStatus', 'jobtype'=>'method', 'class'=>'/ecommerceng/class/business/eCommercePendingWebHook.class.php', 'objectname'=>'eCommercePendingWebHook', 'method'=>'cronCheckWebHooksStatus', 'parameters'=>'', 'comment'=>'Check WebHooks status.', 'frequency'=>15, 'unitfrequency'=>60, 'priority'=>90, 'status'=>0, 'test'=>true),
+			2=>array('label'=>'ECommerceCheckWebHooksStatus', 'jobtype'=>'method', 'class'=>'/ecommerceng/class/business/eCommercePendingWebHook.class.php', 'objectname'=>'eCommercePendingWebHook', 'method'=>'cronCheckWebHooksStatus', 'parameters'=>'', 'comment'=>'Check WebHooks status.', 'frequency'=>15, 'unitfrequency'=>60, 'priority'=>80, 'status'=>0, 'test'=>true),
 		);
 
 		// Permissions