[V3] Override abstract fields in HttpClientRequestMessage #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fannydengdeng
changed the title
xuzhg
approved these changes
Sep 20, 2021
| } | ||
| #endif | ||
|
|
||
| #if !ASTORIA_LIGHT && !PORTABLELIB |
xuzhg
approved these changes
Oct 4, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services targeting .net framework are getting the following error when trying to use Extensions for V3 clients.
This is because the net40 target of ODataLib V3 exposes additional abstract fields in
DataServiceClientRequestMessage. See https://github.com/OData/odata.net/blob/maintenance-5.x/WCFDataService/Client/System/Data/Services/Client/Serialization/DataServiceClientRequestMessage.csThe fix is similar to #43 .