Fix MSVC builds - missing profiling.c #144
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GitMensch
requested changes
May 13, 2024
ddeclerck
force-pushed
the
fix_msvc_builds
branch
from
3f504df
to
f47a5dc
Compare
|
Yes. You can also use a different approach, but ideally we have the help text only once.
|
ddeclerck
force-pushed
the
fix_msvc_builds
branch
from
f47a5dc
to
9cd2dd4
Compare
GitMensch
approved these changes
May 13, 2024
|
Would it be reasonable to get back to #140 after checking in Win32+MacOS changes? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of #110 (comment).
Add missing profiling.c file in MSVC projects.
Also fix usage of preprocessor directives inside macro in
flag.def(MSVC does not seem to like that).