Added config entry for temporary directory #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fank
commented
Aug 19, 2023
| @@ -144,6 +145,7 @@ namespace { | |||
| int httpRequestTimeout{ 120 }; | |||
| int traceLog{ 0 }; | |||
| std::string logsDir{ "./OCAPLOG" }; | |||
| std::string tempDir{ "./OCAPTMP" }; | |||
There was a problem hiding this comment.
@indig0fox with that change it will use this folder by default.
Should i change it back to the old behaviour, so that i will use the default os temp folder until you configure a custom one?
There was a problem hiding this comment.
I think keeping existing log behavior and default folder, and adding a default temp dir alongside it in the Arma root for storing backup .gz, is the most intuitive way forward. I would remove the os default temp folder usage entirely. With this, logs will always tie to recordings in the a3 root regardless of profile, user account, or install environment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And i added a script to build linux based on ubuntu inside docker.