[FIX] product_uom_measure_type: Fixed the issue, that the module cannot be installed #1778

[baguenth]

[FIX] product_uom_measure_type: Fixed the issue, that the module cannot be installed on migrated databases which already have a column 'measure_type'

This pr fixed #1778

@dreispt @legalsylvain @rousseldenis

Kindly ask to check this pr :)

[OCA-git-bot]

Hi @legalsylvain,
some modules you are maintaining are being modified, check this out!

[legalsylvain]

Hi. thanks for fixing that issue !

note : The implementation is correct, but I wonder if it's not better to test if the column exist, and if yes, return and doesn't execute code. if avoids all the UPDATE records that are, I guess useless if the column still exists.
What do you think ?

Kind regards.

[baguenth]

Hi @legalsylvain,

thank you for the quick feedback!

I think we still need to run the update queries. The reason is, that after 13.0 at leaset two new uom categories got introduced: uom_categ_wtime and uom_categ_surface

All three update functions are actually build on top of each other

1. Update measure_type in uom_category --> Here we at least need to set measure_type for uom_categ_wtime and uom_categ_surface
2. Update measure_type in uom_uom, based on uom_category --> Due to 1), there could be a change here
3. Update measure_type in product_template, based on uom_uom --> Due to 2), there could be a change here

Technically we could reduce the update to only handle the new uom categories, in case the column measure_type already exists. This would increase the complexity of the hook a lot, though. Since the update functions do not really hurt and are also uncritical regarding performance, I would rather keep it simple.

[legalsylvain]

Thanks a lot for your explanation !

/ocabot merge patch

[OCA-git-bot]

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1779-by-legalsylvain-bump-patch, awaiting test results.

[OCA-git-bot]

Congratulations, your PR was merged at 30eec92. Thanks a lot for contributing to OCA. ❤️