[16.0][FIX] product_supplierinfo_stock_picking_type: rename on change picking type method #1777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @victoralmau, |
AlexPForgeFlow
changed the title
AlexPForgeFlow
force-pushed
the
16.0-fix-product_supplierinfo_stock_picking_type
branch
from
5c9f2eb
to
7e35f92
Compare
GuillemCForgeFlow
approved these changes
Nov 21, 2024
JordiMForgeFlow
approved these changes
Nov 21, 2024
MiquelRForgeFlow
approved these changes
Nov 21, 2024
… picking type method
AlexPForgeFlow
force-pushed
the
16.0-fix-product_supplierinfo_stock_picking_type
branch
from
7e35f92
to
476055a
Compare
JoanSForgeFlow
approved these changes
Nov 21, 2024
victoralmau
suggested changes
Nov 21, 2024
| def onchange_picking_type_id(self): | ||
| def onchange_picking_type_id_onchange_product(self): | ||
| # Method name is to avoid conflicts with mrp_subcontracting_dropshipping | ||
| # that have an onchange method named onchange_picking_type_id |
There was a problem hiding this comment.
I think you can keep the same method but call the super if the method exists.
if hasattr(super(), "onchange_picking_type_id"):
getattr(super(), "onchange_picking_type_id)
There was a problem hiding this comment.
Hi @victoralmau !
No, as I already mentioned, the Odoo function is overriding the method, so in the module hierarchy, product_supplierinfo_stock_picking_type comes before mrp_subcontracting_dropshipping. For this reason, the method is being overridden. To implement your solution, we would need to add it to Odoo's method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If module mrp_subcontracting_dropshipping, form Odoo, is installed in our system, there are conflicts between onchange methods, mrp_subcontracting_dropshipping method https://github.com/odoo/odoo/blob/16.0/addons/mrp_subcontracting_dropshipping/models/purchase.py#L23 is overriding the onchange method previously defined in this module. So I suggest renaming the onchange method.