Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] product_code_mandatory #1693

Merged
merged 33 commits into from
Aug 2, 2024

Conversation

ced-adhoc
Copy link

@ced-adhoc ced-adhoc commented Jul 26, 2024

Last PR closed for the migration module: #1575.
The closed PR included changes that were incorporated and improved in this PR.
Also please find the mig pr to v17 #1697

agyamuta and others added 30 commits July 26, 2024 16:39
* [ADD] Module to set the  internal reference of the product as required.
Currently translated at 100.0% (3 of 3 strings)

Translation: product-attribute-12.0/product-attribute-12.0-product_code_mandatory
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-12-0/product-attribute-12-0-product_code_mandatory/pt/
Currently translated at 83.3% (5 of 6 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_code_mandatory
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_code_mandatory/fr/
Currently translated at 83.3% (5 of 6 strings)

Translation: product-attribute-14.0/product-attribute-14.0-product_code_mandatory
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-14-0/product-attribute-14-0-product_code_mandatory/fr_FR/
Currently translated at 100.0% (2 of 2 strings)

Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/ca/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/
Currently translated at 100.0% (3 of 3 strings)

Translation: product-attribute-15.0/product-attribute-15.0-product_code_mandatory
Translate-URL: https://translation.odoo-community.org/projects/product-attribute-15-0/product-attribute-15-0-product_code_mandatory/it/
@pedrobaeza
Copy link
Member

/ocabot migration product_code_mandatory

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jul 26, 2024
@OCA-git-bot
Copy link
Contributor

The migration issue (#1157) has not been updated to reference the current pull request because a previous pull request (#1575) is not closed.
Perhaps you should check that there is no duplicate work.
CC @MarioLM-23

@pedrobaeza
Copy link
Member

/ocabot migration product_code_mandatory

@OCA-git-bot OCA-git-bot mentioned this pull request Jul 26, 2024
55 tasks
@rov-adhoc rov-adhoc force-pushed the 16.0-mig-product_code_mandatory-1 branch from 86ecd16 to 5946343 Compare July 26, 2024 20:59
@ced-adhoc ced-adhoc force-pushed the 16.0-mig-product_code_mandatory-1 branch from 65e808b to 8c035c7 Compare July 30, 2024 15:23
Copy link

@florenciafrigieri2 florenciafrigieri2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Functional review, working ok. The internal reference is automatically fulfilled for the products and variants if it is empty.

@jcadhoc
Copy link

jcadhoc commented Jul 31, 2024

@pedrobaeza Hi Pedro, Same case in this pr, i think we can merge.

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The migration commit contains changes that don't belong here, and the second commit, if they are migration reviews, should be squashed into the migration commit.

@ced-adhoc ced-adhoc force-pushed the 16.0-mig-product_code_mandatory-1 branch from 8c035c7 to 0380300 Compare August 1, 2024 15:04
@ced-adhoc
Copy link
Author

The migration commit contains changes that don't belong here, and the second commit, if they are migration reviews, should be squashed into the migration commit.

@pedrobaeza
Reverted changes that don't belong to the module product_code_mandatory in the migration commit.

README.md Outdated Show resolved Hide resolved
Move setUp test class to setUpClass for better performant

[ADD] product_code_mandatory: Add contributors
@ced-adhoc ced-adhoc force-pushed the 16.0-mig-product_code_mandatory-1 branch from 0380300 to 8cad0d7 Compare August 2, 2024 12:45
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 16.0-ocabot-merge-pr-1693-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 9d3d06c into OCA:16.0 Aug 2, 2024
8 of 9 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 749acae. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.