Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] hr_employee_firstname: translate name order config value #1385

Open
wants to merge 1 commit into
base: 16.0
Choose a base branch
from

Conversation

benwillig
Copy link

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @luisg123v, @Savoir-faire Linux,
some modules you are maintaining are being modified, check this out!

Copy link
Contributor

@luisg123v luisg123v left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing commit description.

@@ -4,8 +4,10 @@
#
msgid ""
msgstr ""
"Project-Id-Version: Odoo Server 16.0\n"
"Project-Id-Version: Odoo Server 16.0+e\n"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Avoid these changes because they will be reverted by the bot anyway.

I'd suggest modifying just the Python code or in fault modifying also the .pot file but only terms related to your change.

Copy link
Author

@benwillig benwillig Aug 2, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Won't weblate override it anyway and do a msgmerge with the new translations from the .po ? I needed the translations now but yes I can remove theses changes if needed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants