Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP] account_invoice_import: fwd ports for ATI Support (tests) #827

Merged
merged 2 commits into from
Nov 1, 2023
Merged

[14.0][IMP] account_invoice_import: fwd ports for ATI Support (tests) #827

merged 2 commits into from
Nov 1, 2023

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Oct 8, 2023 •
edited
Loading

Forward porting the tests for ATI support.
ATI Support depends on: #826

One of commits needed to support ATI as mentioned in #293

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

@bosd
Copy link
Contributor Author

bosd commented Oct 31, 2023

/ocabot rebase

@OCA-git-bot
Copy link
Contributor

Sorry @bosd you are not allowed to rebase.

To do so you must either have push permissions on the repository, or be a declared maintainer of all modified addons.

If you wish to adopt an addon and become it's maintainer, open a pull request to add your GitHub login to the maintainers key of its manifest.

@bosd bosd force-pushed the 14.0-fwd-prts-account_invoice_import branch from 4018d6b to 2d9942a Compare October 31, 2023 19:28
@bosd
Copy link
Contributor Author

bosd commented Oct 31, 2023

@Dranyel-Bosd Can you please review?

Dranyel-Bosd
Dranyel-Bosd approved these changes Nov 1, 2023
View reviewed changes
Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Look so good to me

@bosd
Copy link
Contributor Author

bosd commented Nov 1, 2023

@etobella, @simahawk Can you please review?

etobella
etobella approved these changes Nov 1, 2023
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-827-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 4e28fe3 into OCA:14.0 Nov 1, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 433c910. Thanks a lot for contributing to OCA. ❤️

@bosd bosd deleted the 14.0-fwd-prts-account_invoice_import branch November 1, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etobella etobella etobella approved these changes

@Dranyel-Bosd Dranyel-Bosd Dranyel-Bosd approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@bosd @OCA-git-bot @etobella @Dranyel-Bosd @yvaucher @i-vyshnevska