Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[14.0] edi: fix handling of archived types and rules #824

Merged
merged 3 commits into from
Oct 4, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion edi_oca/models/edi_exchange_type.py
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ class EDIExchangeType(models.Model):
_name = "edi.exchange.type"
_description = "EDI Exchange Type"

active = fields.Boolean(default=True)
active = fields.Boolean(default=True, inverse="_inverse_active")
backend_id = fields.Many2one(
string="Backend",
comodel_name="edi.backend",
Expand Down Expand Up @@ -161,6 +161,12 @@ class EDIExchangeType(models.Model):
)
]

def _inverse_active(self):
for rec in self:
# Disable rules if type gets disabled
if not rec.active:
rec.rule_ids.active = False

@api.depends("advanced_settings_edit")
def _compute_advanced_settings(self):
for rec in self:
Expand Down
22 changes: 22 additions & 0 deletions edi_oca/tests/test_exchange_type.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,3 +123,25 @@ def test_filename_pattern_settings(self):
date_pattern: '%Y-%m-%d-%H-%M'
"""
self._test_exchange_filename("Test-File-2022-04-28-10-37.csv")

def test_archive_rules(self):
exc_type = self.exchange_type_out
rule1 = exc_type.rule_ids.create(
{
"type_id": exc_type.id,
"name": "Fake partner rule",
"model_id": self.env["ir.model"]._get("res.partner").id,
}
)
rule2 = exc_type.rule_ids.create(
{
"type_id": exc_type.id,
"name": "Fake user rule",
"model_id": self.env["ir.model"]._get("res.users").id,
}
)
exc_type.active = False
rule1.invalidate_cache()
rule2.invalidate_cache()
self.assertFalse(rule1.active)
self.assertFalse(rule2.active)
11 changes: 9 additions & 2 deletions edi_oca/views/edi_exchange_type_views.xml
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@
context="{'default_type_id': active_id}"
>
<tree decoration-muted="(not active)">
<field name="active" invisible="1" />
<field name="active" widget="boolean_toggle" />
<field name="name" />
<field name="model_id" />
<field name="kind" />
Expand Down Expand Up @@ -168,7 +168,14 @@
<field name="view_mode">tree,form</field>
<field name="search_view_id" ref="edi_exchange_type_view_search" />
<field name="domain">[]</field>
<field name="context">{'search_default_filter_all': 1}</field>
<!--
`active_test` here is fundamental to see archived `rule_ids`.
Reason: when related fields are loaded with a `read`
the ctx that you could set at field level on the view is lost.
-->
<field
name="context"
>{'search_default_filter_all': 1, 'active_test': False}</field>
</record>
<record
model="ir.actions.act_window.view"
Expand Down
Loading