Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] sale_order_import: Migration to 16.0 #816

Merged
merged 81 commits into from
Oct 19, 2023

Conversation

QuocDuong1306
Copy link

No description provided.

alexis-via and others added 30 commits September 19, 2023 15:07
…, sale_order_import_ubl, sale_order_import_csv, sale_order_ubl, sale_commercial_partner
Add another README.
because we want to have access to the code of the modules that inherit business.document.import
Add support for partner bank matching on invoice update (before, it was only supported on invoice creation)
Rename __openerp__.py to __manifest__.py and set installable to False
… module

Fix spelling mistake and other remarks on README by Tarteo
…o v10.0

base_business_document_import: Add support for the creation of res.bank
Add ubl invoice generation option in accounting config page
Add method to create SO in sale.order.import accessible via JSON-RPC
… has visible discounts

Code improvements in sale_order_import
Add unit tests in sale_order_import
Use display_name instead of name_get()[0][1]

Fix travis
…iness document is imported in the right company
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: edi-13.0/edi-13.0-sale_order_import
Translate-URL: https://translation.odoo-community.org/projects/edi-13-0/edi-13-0-sale_order_import/
…tner matching.

A shipping partner is not especially related to the ordering party. It
could be any partner. However, we want to ensure that the address is
respected.

Fix-up: PartyIdentification/ID is a 1..N relation. Parse each of them for a match
Do not suggest to update an open quotation that does not have the
corresponding client ref. UBL endpoint was blocked as soon as a
quotation for the same customer was existing.
@QuocDuong1306 QuocDuong1306 marked this pull request as ready for review October 10, 2023 09:16
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall

sale_order_import/models/sale.py Outdated Show resolved Hide resolved
b"<?xml version='1.0' encoding='utf-8'?><root><foo>baz</foo></root>"
)
order_filename = "test_order.xml"
with self.assertRaises(exceptions.UserError):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

?

duongtq added 2 commits October 11, 2023 09:51
- Add new selection import_type field for choosing the type to import
- Refactor _parse_file with import_type field
- Drop some not used method
@QuocDuong1306
Copy link
Author

@simahawk , I updated

Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG

Copy link
Member

@yvaucher yvaucher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yvaucher
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-816-by-yvaucher-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Oct 19, 2023
Signed-off-by yvaucher
@yvaucher
Copy link
Member

Note: we can search for a better method for the TODO about currency later, I'm not aware of one neither.

@OCA-git-bot
Copy link
Contributor

@yvaucher your merge command was aborted due to failed check(s), which you can inspect on this commit of 16.0-ocabot-merge-pr-816-by-yvaucher-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@yvaucher
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-816-by-yvaucher-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit fb83ded into OCA:16.0 Oct 19, 2023
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 32a0e49. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.