Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FIX] base_business_document_import: fixed typo in _match_tax method #807

Merged
merged 1 commit into from
Nov 3, 2023
Merged

[FIX] base_business_document_import: fixed typo in _match_tax method #807

merged 1 commit into from
Nov 3, 2023

Conversation

gediminasvenc
Copy link

Fixed typo in _match_tax method, because of this typo proper error message could not be raised for the end user if tax match could not be found

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

bosd
bosd approved these changes Sep 30, 2023
View reviewed changes
Copy link
Contributor

@bosd bosd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bosd
Copy link
Contributor

bosd commented Nov 3, 2023

@etobella, @oca/edi-maintainers Can you merge this one? 🙏

etobella
etobella approved these changes Nov 3, 2023
View reviewed changes
Copy link
Member

@etobella etobella left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-807-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 597444b into OCA:16.0 Nov 3, 2023
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1c46111. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rvalyi rvalyi rvalyi approved these changes

@bealdav bealdav bealdav approved these changes

@bosd bosd bosd approved these changes

@etobella etobella etobella approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@gediminasvenc @OCA-git-bot @bosd @rvalyi @bealdav @etobella