Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0] edi_oca: fix count EDI exhange record using consume mixin #790

Merged
merged 1 commit into from
Aug 30, 2023
Merged

[14.0] edi_oca: fix count EDI exhange record using consume mixin #790

merged 1 commit into from
Aug 30, 2023

Conversation

petrus-v
Copy link
Contributor

No description provided.

@OCA-git-bot
Copy link
Contributor

Hi @simahawk, @etobella,
some modules you are maintaining are being modified, check this out!

simahawk
simahawk requested changes Aug 26, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch thanks!
One detail: pls rewrite the commit msg to remove the odoo serie and fix typos.
Eg: edi_oca: fix consumer mixin exchange record count

@simahawk simahawk mentioned this pull request Aug 26, 2023
Merged
@petrus-v petrus-v force-pushed the 14.0-edi_oca-fix-compute-record branch from 688221e to 36cfb7b Compare August 28, 2023 10:14
@petrus-v
Copy link
Contributor Author

Good catch thanks! One detail: pls rewrite the commit msg to remove the odoo serie and fix typos. Eg: edi_oca: fix consumer mixin exchange record count

done !

@simahawk
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-790-by-simahawk-bump-patch, awaiting test results.

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@OCA-git-bot OCA-git-bot merged commit 3a492ed into OCA:14.0 Aug 30, 2023
6 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 79bf87d. Thanks a lot for contributing to OCA. ❤️

@etobella etobella mentioned this pull request Sep 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@etobella etobella etobella approved these changes

@JaumeBforgeFlow JaumeBforgeFlow JaumeBforgeFlow approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@petrus-v @OCA-git-bot @simahawk @etobella @JaumeBforgeFlow