Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][MIG] account_invoice_import #753

Draft
wants to merge 151 commits into
base: 16.0
Choose a base branch
from

Conversation

alexis-via
Copy link
Contributor

This is a draft PR. Many more changes are planned.

alexis-via and others added 30 commits March 23, 2023 17:56
FIX raise error when we don't identify a partner

Update README
Rename test/pdf/ to test/invoices/ to host XML invoices too
…invoice_zugferd (see README.rst for more info)

Move the ZUGFeRD/CII-specific code of account_invoice_import to account_invoice_import_zugferd
Disable test of invoice2data, because this lib is difficult to install
Add support for UBL refunds

If you have an UBL refund that I could use to test, please contact me !
Convert YAML test to unittest
…edicated module account_invoice_import_invoice2data

Update README.rst and headers to latest OCA conventions.
Better key names in the parsed_inv dict
parsed_inv doesn't need to be JSON serializable anymore (small drawback: the invoice is parsed a second time on the second step... but the second step is rarely used)
Move code from account_invoice_import_invoice2data to account_invoice_import
Update REAME and some interface strings about UBL being an ISO standard
Small code changes
…voice dict, cleaner organisation)

Code refactoring: move code in base_business_document_import, factorise code for tax matching (it was duplicated in UBL and ZUGFeRD)
Now support PDF with embedded UBL XML file
Enable unittests on account_invoice_import_ubl
More absolute xpath in account_invoice_import_ubl instead of relative xpath

WARNING: these are big changes, I may have broken a few details
Adapt module account_invoice_import_ubl to use the new base_ubl module
Small fixes
Add unitests in base_business_document_import
Small code enhancements/simplifications
Code cleanup/minor changes
alexis-via and others added 11 commits March 23, 2023 17:56
FIX import of XML files via mail gateway
FIX attachment number in logs
Currently translated at 94.3% (100 of 106 strings)

Translation: edi-14.0/edi-14.0-account_invoice_import
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-account_invoice_import/fr/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: edi-14.0/edi-14.0-account_invoice_import
Translate-URL: https://translation.odoo-community.org/projects/edi-14-0/edi-14-0-account_invoice_import/
The method get_invoice_line_account() was removed from the "account"
module in odoo v13. So we now use the underlying method get_product_accounts()
Fixes bug OCA#572
First draft migration, to have a first working version. Many more
changes are planned.
Copy link
Collaborator

@njeudy njeudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok I test a try to review code on V16 community and V16 enterprise :) Ok for me

There is an other PR for this : #752

@njeudy
Copy link
Collaborator

njeudy commented May 8, 2023

Think I wrongly approve this (mistake with account_invoice_download) sorry !

@njeudy njeudy self-requested a review May 8, 2023 13:08
Copy link
Collaborator

@njeudy njeudy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is two PR for this one: #752

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 10, 2023
@gurneyalex gurneyalex added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Sep 26, 2023
@gurneyalex
Copy link
Member

Hello @alexis-via what is the status of this pull request?

@gurneyalex
Copy link
Member

#938 is the same PR, rebased, with the tests fixed.

@simahawk
Copy link
Contributor

simahawk commented Mar 5, 2024

@alexis-via ping. Shall we keep this or move on w/ #938 ?

@bosd
Copy link
Contributor

bosd commented Sep 18, 2024

Shall we keep this or move on w/ #938 ?

In the meantime #938 is closed. So maybe this one??

Add support for discount on lines in the multi-line create scenario
Fix force tax scenario and simplify the code
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.