Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] edi_voxel_sale_order_import: Migration to version 15.0 #678

Merged
merged 13 commits into from
Jan 16, 2024

Conversation

sergio-teruel
Copy link
Contributor

@sergio-teruel sergio-teruel commented Nov 2, 2022

Copy link

@carlosdauden carlosdauden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Migration commit LGTM

@sergio-teruel sergio-teruel force-pushed the 15.0-mig-edi_voxel_sale_order_import branch from b154b36 to 0a74aa0 Compare December 14, 2022 13:52
@sergio-teruel
Copy link
Contributor Author

Rebase done

@sergio-teruel sergio-teruel force-pushed the 15.0-mig-edi_voxel_sale_order_import branch from 0a74aa0 to 4a692b0 Compare March 20, 2023 13:30
@pedrobaeza pedrobaeza changed the title [WIP][15.0][MIG] edi_voxel_sale_order_import: Migration to version 15.0 [15.0][MIG] edi_voxel_sale_order_import: Migration to version 15.0 Apr 16, 2023
@pedrobaeza
Copy link
Member

@sergio-teruel as this depends on onchange_helper that is Beta, it can't be Production/Stable. Please change status or promote onchange_helper to Stable.

@pedrobaeza
Copy link
Member

/ocabot migration edi_voxel_sale_order_import

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Aug 14, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request May 26, 2023
35 tasks
@pedrobaeza pedrobaeza force-pushed the 15.0-mig-edi_voxel_sale_order_import branch 2 times, most recently from cae2ce5 to c8ead5b Compare August 14, 2023 09:56
@pedrobaeza
Copy link
Member

@simahawk why a module with a name pdf_helper is here in OCA/edi? Is doesn't make too much sense. Anyway, their tests are failing, as TreeCase doesn't exist. Please fix it, as it's blocking this PR.

@sergio-teruel sergio-teruel force-pushed the 15.0-mig-edi_voxel_sale_order_import branch from c8ead5b to d7e03d2 Compare September 11, 2023 12:26
@pedrobaeza
Copy link
Member

Please check CI

@simahawk
Copy link
Contributor

@simahawk why a module with a name pdf_helper is here in OCA/edi? Is doesn't make too much sense. Anyway, their tests are failing, as TreeCase doesn't exist. Please fix it, as it's blocking this PR.

It has been ripped out of business document import in 14 a long time ago and I didn't want to move it to minimize the impact on everybody else. I'm not against moving it (maybe to server-tools).

@pedrobaeza
Copy link
Member

Well, that one is making the CI to fail. Please check at least that. And with pip, it's supposed that the OCA repo where it's hosted is not important.

@simahawk
Copy link
Contributor

Well, that one is making the CI to fail. Please check at least that. And with pip, it's supposed that the OCA repo where it's hosted is not important.

Not for CI, or for me. Is for the ones not relying on it 😉

Et voilá #811

Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 14, 2024
@carlosdauden
Copy link

@sergio-teruel rebase to test

Ernesto Tejeda and others added 8 commits January 16, 2024 00:33
This module allows users to import automatically sale orders from Voxel
[FIX] edi_voxel_sale_order_import: Protect views with groups

[FIX+IMP] edi_voxel_sale_order_import: Fine-tuning on the module

[FIX] edi_voxel_sale_order_import: Propagate company

[FIX] edi_voxel_sale_order_import: Fix test

[FIX+IMP] edi_voxel_sale_order_import: Raise if product not found + company UI reorder + play onchanges

[FIX] edi_voxel_sale_order_import: Add ref to customers parser

[FIX] edi_voxel_sale_order_import: Simulate a real order for getting line vals

[FIX] edi_voxel_sale_order_import: Better SO creation

Previous one was a hack.
[FIX] edi_voxel_sale_order_import: Ref goes to client_order_ref, not to origin

[FIX] edi_voxel_sale_order_import: Fix test
Ernesto Tejeda and others added 4 commits January 16, 2024 00:33
After assigning the partner, we need to populate expected values for
such partner, using `play_onchanges`.
If we set initially a pricelist, when playing onchanges on the partner,
the pricelist will remain the same, no matter the pricelist associated
to the partner. As we want to use the partner's pricelist, we remove
the initial pricelist assignation.
Use the same technique for qualifying the product (but reversed) than
used on pickings:

- See if there's a product with the reference.
- If not, check for a customerinfo record with such code, first on
  the order partner, and if not found yet, on the commercial entity.

Note that here the CustomerSKU/SupplierSKU seems to be swapped from
their normal use in pickings/invoices according to empirical samples.

TT30469

Co-Authored-By: Pedro M. Baeza <[email protected]>
@sergio-teruel sergio-teruel force-pushed the 15.0-mig-edi_voxel_sale_order_import branch from d7e03d2 to bf15e4f Compare January 15, 2024 23:33
@sergio-teruel
Copy link
Contributor Author

Done!

Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-678-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jan 16, 2024
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

@pedrobaeza your merge command was aborted due to failed check(s), which you can inspect on this commit of 15.0-ocabot-merge-pr-678-by-pedrobaeza-bump-nobump.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

@pedrobaeza pedrobaeza force-pushed the 15.0-mig-edi_voxel_sale_order_import branch from bf15e4f to 455556e Compare January 16, 2024 07:47
@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-678-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 97cae94 into OCA:15.0 Jan 16, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 1c9f8d0. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged 🎉 stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants