Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][IMP][FIX] account_invoice_import_invoice2data add line support and additional partner fields #573

Merged
merged 6 commits into from
Nov 2, 2023
Merged

[14.0][IMP][FIX] account_invoice_import_invoice2data add line support and additional partner fields #573

merged 6 commits into from
Nov 2, 2023

Conversation

bosd
Copy link
Contributor

@bosd bosd commented Apr 27, 2022 •
edited
Loading

a121bb6d-91b3-4233-b89a-af9dd03a6cf1.webm

add support for:
Invoice lines

  • discount
  • price_subtotal
  • date_start + date_end
  • uom_dict
    • unece_code
    • name
  • Product dict
    • barcode
    • code
  • tax dict
    • amount
    • vat_percent
    • price_include True of False (preparation for future Support for ATI All tax included)
  • Invoice line notes // upstream support in account_invoice_import to be implemented
  • Invoice line sectionheader // upstream support in account_invoice_import to be implemented

partner fields:

  • Chamber of Commerce Number
  • bic
  • iban
  • note
  • phone
  • street
  • street2
  • city
  • zip
  • country_code

Global invoice fields:

  • note (will be imported in the chatter)

  • narration (no support yet in account_invoice_import) Will be imported in bottom of invoice page

  • Improve documentation

todo:

  • add unit tests and test invoice

Leave other keys and values in tact so they could be processed by addons downstream.

related to issue: #568

Keep compatability with template builder: #399
Use standard field names: invoice-x/invoice2data#313 (comment)

@OCA-git-bot
Copy link
Contributor

Hi @alexis-via,
some modules you are maintaining are being modified, check this out!

@bosd bosd changed the title [14.0] IMP-FIX add line and additional partner fields [14.0] account_invoice_import_invoice2data IMP-FIX add line and additional partner fields Apr 27, 2022
@bosd
Copy link
Contributor Author

bosd commented May 13, 2022 •
edited
Loading

/ocabot needs review

@bosd bosd force-pushed the inv2data-lines-fix branch 2 times, most recently from 7d50eb2 to e77e5b6 Compare May 13, 2022 18:47
@bosd bosd mentioned this pull request Jun 3, 2022
Closed
@bosd
Copy link
Contributor Author

bosd commented Jun 3, 2022

I'd say this one is ready for review.
Some tests could be added.
Maybe a small improvement, in case there is no partner name passed from the invoice2data library, use the issuer field instead.

FYI, I'm currently working on adding section header and note lines support in the account invoice import module.

@bosd bosd mentioned this pull request Jul 8, 2022
Closed
@bosd bosd changed the title [14.0] account_invoice_import_invoice2data IMP-FIX add line and additional partner fields [14.0][IMP][FIX] account_invoice_import_invoice2data add line support and additional partner fields Jul 8, 2022
@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 15, 2023
@bosd
Copy link
Contributor Author

bosd commented Feb 6, 2023

Please remove the stale label. I am still working on this. Even in conjunction with invoice2data lib.

Will add some tests/examples

@github-actions github-actions bot removed the stale PR/Issue without recent activity, it'll be soon closed automatically. label Feb 12, 2023
@bosd bosd force-pushed the inv2data-lines-fix branch 7 times, most recently from e7247a8 to 70bd0ba Compare March 4, 2023 12:44
@bosd bosd force-pushed the inv2data-lines-fix branch 2 times, most recently from 6fbc096 to 9dd3ef4 Compare March 21, 2023 18:22
@bosd bosd force-pushed the inv2data-lines-fix branch 4 times, most recently from 1dfcf8d to c4178fe Compare April 12, 2023 23:23
@bosd
Copy link
Contributor Author

bosd commented Apr 13, 2023 •
edited
Loading

All green!! It's ready now,
@MTantin, @bofiltd, @bealdav Can you please review?

@etobella
Copy link
Member

/ocabot rebase

@bosd @OCA-git-bot
[IMP] account_invoice_import_invoice2data: Buildout invoice dict
9b8c70e 
add all available partner, invoice and invoiceline fields
@OCA-git-bot
Copy link
Contributor

Congratulations, PR rebased to 14.0.

@bosd
Copy link
Contributor Author

bosd commented Sep 27, 2023

👏 All green now.. After some while using this in production. A few usability and doc improvements have been made.
Is this one a go now? 🙏

@bosd bosd force-pushed the inv2data-lines-fix branch 4 times, most recently from 6a6192e to 5fed6c5 Compare October 7, 2023 18:13
@bosd
Copy link
Contributor Author

bosd commented Oct 7, 2023

Hmm, I keep fighting the runboat.
On local system, demo data is loaded fine.
Runboat still does'nt want to load it.

temporarily gonna comment out the line..
It will create an extra adjustment line on the imported invoice of AzureInterior. No biggy.

Dranyel-Bosd
Dranyel-Bosd approved these changes Oct 9, 2023
View reviewed changes
Copy link

@Dranyel-Bosd Dranyel-Bosd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Screencast.from.2023-10-09.16-31-09.webm

@bosd bosd requested a review from simahawk October 9, 2023 09:24
simahawk
simahawk approved these changes Oct 10, 2023
View reviewed changes
Copy link
Contributor

@simahawk simahawk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LG overall. Just code review.
Some small remarks.
Pre-approving.

account_invoice_import_invoice2data/readme/CONFIGURE.rst Show resolved Hide resolved
account_invoice_import_invoice2data/wizard/account_invoice_import.py Outdated Show resolved Hide resolved
account_invoice_import_invoice2data/wizard/account_invoice_import.py Outdated Show resolved Hide resolved
@bosd
Copy link
Contributor Author

bosd commented Nov 2, 2023

@oca/edi-maintainers Can we get a merge?

@etobella
Copy link
Member

etobella commented Nov 2, 2023

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-573-by-etobella-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4f9f92f into OCA:14.0 Nov 2, 2023
6 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at abb0819. Thanks a lot for contributing to OCA. ❤️

@bosd bosd deleted the inv2data-lines-fix branch November 2, 2023 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simahawk simahawk simahawk approved these changes

@etobella etobella etobella approved these changes

@bofiltd bofiltd bofiltd approved these changes

@Dranyel-Bosd Dranyel-Bosd Dranyel-Bosd approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@bosd @OCA-git-bot @bealdav @simahawk @etobella @bofiltd @Dranyel-Bosd