[15.0][FIX] base_import_pdf_by_template: Improve the import process to account for fixed values #1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victoralmau
force-pushed
the
15.0-fix-base_import_pdf_by_template-TT50650
branch
from
6222978
to
b2c1fab
Compare
victoralmau
changed the title
pedrobaeza
reviewed
Sep 7, 2024
base_import_pdf_by_template/wizards/wizard_base_import_pdf_upload.py
Outdated
Show resolved
Hide resolved
…unt for fixed values When fixed values are defined, default_x was used in the context of Form() but in some cases this was not respected (for example if the value was changed in an onchange, warehouse_id field of sale orders). We changed the way of creating the records to always take into account the fixed values. TT50650
victoralmau
force-pushed
the
15.0-fix-base_import_pdf_by_template-TT50650
branch
from
b2c1fab
to
10e5c1b
Compare
|
What a great day to merge this nice PR. Let's do it! |
|
This PR has the |
1 similar comment
|
This PR has the |
|
Congratulations, your PR was merged at d59e4bb. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve the import process to account for fixed values
When fixed values are defined, default_x was used in the context of Form() but in some cases this was not respected (for example if the value was changed in an onchange,
warehouse_idfield of sale orders).We changed the way of creating the records to always take into account the fixed values.
Please @pedrobaeza and @pilarvargas-tecnativa can you review it?
@Tecnativa TT50650