-
-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][IMP] base_edi: introduce a basic edi user group (Backport from 16.0) #1005
Conversation
Hi @simahawk, |
|
Hi @pedrobaeza , I have a suggestion from @simahawk (here) Btw, in many repositories, I saw a |
OK about the attribution. I thought it was from other author. It's good that you link the original pull request for avoiding these misunderstandings. About the commit message, it's not correct although some use them: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message |
This commit was merged on 16.0. Do we need to change the commit message? If yes, which message do you suggest for this one (It will be helpful for me to contribute to OCA at the other times also) |
I think the only problem is to put |
/ocabot merge minor |
On my way to merge this fine PR! |
Congratulations, your PR was merged at 5c2f1a4. Thanks a lot for contributing to OCA. ❤️ |
A suggestion from the author (of the module) @simahawk