Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][IMP] base_edi: introduce a basic edi user group (Backport from 16.0) #1005

Merged
merged 1 commit into from
Jul 10, 2024

Conversation

QuocDuong1306
Copy link

@QuocDuong1306 QuocDuong1306 commented Jul 10, 2024

@OCA-git-bot
Copy link
Contributor

Hi @simahawk,
some modules you are maintaining are being modified, check this out!

@pedrobaeza
Copy link
Member

[BKP] doesn't exit as tag, as why not cherry-picking the commit from 16.0? You are removing the attribution.

@pedrobaeza pedrobaeza added this to the 15.0 milestone Jul 10, 2024
@QuocDuong1306
Copy link
Author

Hi @pedrobaeza , I have a suggestion from @simahawk (here)

Btw, in many repositories, I saw a [BKP] tag is used for this case (Backport), Did I miss sth, could you suggest it?

@pedrobaeza
Copy link
Member

OK about the attribution. I thought it was from other author. It's good that you link the original pull request for avoiding these misunderstandings.

About the commit message, it's not correct although some use them: https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#commit-message

@QuocDuong1306
Copy link
Author

This commit was merged on 16.0. Do we need to change the commit message? If yes, which message do you suggest for this one (It will be helpful for me to contribute to OCA at the other times also)

@pedrobaeza
Copy link
Member

I think the only problem is to put [BKP] in the PR title. The commit message already contains [IMP].

@simahawk simahawk changed the title [15.0][BKP] base_edi: introduce a basic edi user group (Backport from 16.0) [15.0][IMO] base_edi: introduce a basic edi user group (Backport from 16.0) Jul 10, 2024
@simahawk simahawk changed the title [15.0][IMO] base_edi: introduce a basic edi user group (Backport from 16.0) [15.0][IMP] base_edi: introduce a basic edi user group (Backport from 16.0) Jul 10, 2024
@simahawk
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 15.0-ocabot-merge-pr-1005-by-simahawk-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 114e6fa into OCA:15.0 Jul 10, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 5c2f1a4. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants