Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][IMP] account_payment_return, new reason action type #316

Open
wants to merge 3 commits into
base: 12.0
Choose a base branch
from

Conversation

qgroulard
Copy link

Add a field 'Next Action' on a payment return reason.

This field is meant to categorize payment returns by the action to take when received.
For instance, 'Next Action' could be 'Renew mandate', 'Update BIC' or 'Contact Customer'.

@qgroulard qgroulard force-pushed the 12.0-account_payment_return_reason_action_type-qgr branch 2 times, most recently from 3dd3648 to b920871 Compare February 10, 2020 13:14
@kittiu
Copy link
Sponsor Member

kittiu commented Mar 17, 2020

Hi @qgroulard
I am testing this PR, but AFIK, it simply add new m2o data field in the reasons. Which i don't see how it will be useful yet (i.e., no report related to it).
May be you can explain the real use of this PR ? :)
Thanks!

@kittiu
Copy link
Sponsor Member

kittiu commented Mar 17, 2020

By the way, can you help change the title of this PR to be,
[12.0][IMP] account_payment_return, new reason action type
That would make it search easily. :)

@qgroulard
Copy link
Author

Hi @qgroulard
I am testing this PR, but AFIK, it simply add new m2o data field in the reasons. Which i don't see how it will be useful yet (i.e., no report related to it).
May be you can explain the real use of this PR ? :)
Thanks!

Hi @kittiu
Indeed this PR adds a new m2o field with no further logic.
My customer needed to be able to filter returned payments based on the next thing to do.
This helps to treat them in mass and to assign actions to employees (i.e. the guy who is responsible for renewing mandates might not be the same that the one who should call the customers).

I thought it could already benefit to others as is.

@qgroulard qgroulard changed the title [12.0] [ADD] Account payment return reason action type [12.0][IMP] account_payment_return, new reason action type Mar 17, 2020
@kittiu
Copy link
Sponsor Member

kittiu commented Mar 20, 2020

@qgroulard thanks for explaining. But so, I am not so sure it can benefit other.
You can just add this field on your custom module, don't you?

Let's wait for others opinion :)

@sbejaoui sbejaoui force-pushed the 12.0-account_payment_return_reason_action_type-qgr branch from b920871 to efe892a Compare July 14, 2020 14:27
@sbejaoui
Copy link
Contributor

I rebased this PR on #338 to be able to add the new field next_action_type_id to the payment return reason form view

Fix payment_return_reason_action_type file name
@sbejaoui sbejaoui force-pushed the 12.0-account_payment_return_reason_action_type-qgr branch from efe892a to d639411 Compare July 14, 2020 14:43
@enricostano
Copy link

Hi @qgroulard , does this PR allows to generate an invoice to charge the customer dunning expenses? Thanks!

@qgroulard
Copy link
Author

Hi @qgroulard , does this PR allows to generate an invoice to charge the customer dunning expenses? Thanks!

Hello @enricostano, it does not automatically.
At least it can help mark the returns as 'Next action: generate dunning invoice" so that user can easily retrieve them and create the invoices manually.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jan 30, 2022
@github-actions github-actions bot closed this Mar 6, 2022
@sbidoul sbidoul reopened this Jan 26, 2023
@sbidoul sbidoul added no stale Use this label to prevent the automated stale action from closing this PR/Issue. and removed stale PR/Issue without recent activity, it'll be soon closed automatically. labels Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no stale Use this label to prevent the automated stale action from closing this PR/Issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants