Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adds server url template abnf #4264

Open
wants to merge 8 commits into
base: v3.2-dev
Choose a base branch
from

Conversation

baywet
Copy link
Contributor

@baywet baywet commented Dec 18, 2024

partial #3256
related #4244

@baywet baywet requested review from a team as code owners December 18, 2024 12:59
@baywet
Copy link
Contributor Author

baywet commented Dec 18, 2024

CC @char0n @ralfhandl @handrews

src/oas.md Show resolved Hide resolved
@ralfhandl ralfhandl changed the title docs: adds server url template anbf docs: adds server url template abnf Dec 18, 2024
@handrews
Copy link
Member

After discussion in TDC we agreed that pchar is not the right rule and we should use the general literals per RFC6570.

@baywet baywet requested review from ralfhandl and char0n December 19, 2024 18:28
src/oas.md Outdated Show resolved Hide resolved
@baywet baywet requested a review from char0n December 19, 2024 19:41
src/oas.md Outdated Show resolved Hide resolved
@baywet
Copy link
Contributor Author

baywet commented Dec 19, 2024

@handrews @char0n @ralfhandl I think we're ready for final review here :)

src/oas.md Outdated Show resolved Hide resolved
src/oas.md Outdated Show resolved Hide resolved
Copy link
Contributor

@ralfhandl ralfhandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/oas.md Outdated Show resolved Hide resolved
@baywet baywet requested review from char0n and ralfhandl December 20, 2024 13:45
Copy link
Contributor

@char0n char0n left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, I've tested it as well, compiles and parses correctly.

src/oas.md Outdated Show resolved Hide resolved
@baywet baywet requested a review from char0n December 23, 2024 12:32
@handrews
Copy link
Member

Random question- why does this PR start with "docs:"? It's a spec PR, not a docs PR. I keep overlooking it because of this.

@baywet
Copy link
Contributor Author

baywet commented Dec 23, 2024

Random question- why does this PR start with "docs:"? It's a spec PR, not a docs PR. I keep overlooking it because of this.

Muscle memory: on most repos I work on, we follow semantic commits. And usually when I touch Md files there, it's documentation.

GitHub CLI: -f uses the first commit when creating a PR.

@baywet baywet changed the title docs: adds server url template abnf adds server url template abnf Dec 23, 2024
@handrews
Copy link
Member

@baywet thank you for satisfying my curiosity! Yeah, this project is a little unusual in that the spec markdown is really the "source". "Docs" to me are things like CONTRIBUTING.md and the README.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants