-
Notifications
You must be signed in to change notification settings - Fork 9.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
adds server url template abnf #4264
base: v3.2-dev
Are you sure you want to change the base?
Conversation
Signed-off-by: Vincent Biret <[email protected]>
After discussion in TDC we agreed that |
Signed-off-by: Vincent Biret <[email protected]>
Co-authored-by: Vladimír Gorej <[email protected]>
Signed-off-by: Vincent Biret <[email protected]>
@handrews @char0n @ralfhandl I think we're ready for final review here :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Align with https://www.rfc-editor.org/errata/eid6937
Co-authored-by: Ralf Handl <[email protected]>
…r diverging future updates Signed-off-by: Vincent Biret <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, I've tested it as well, compiles and parses correctly.
Co-authored-by: Vladimír Gorej <[email protected]>
Random question- why does this PR start with "docs:"? It's a spec PR, not a docs PR. I keep overlooking it because of this. |
Muscle memory: on most repos I work on, we follow semantic commits. And usually when I touch Md files there, it's documentation. GitHub CLI: -f uses the first commit when creating a PR. |
@baywet thank you for satisfying my curiosity! Yeah, this project is a little unusual in that the spec markdown is really the "source". "Docs" to me are things like CONTRIBUTING.md and the README. |
partial #3256
related #4244