Update BPMNDiscovery.java

NourEldin-Ali · Jun 11, 2024 · 276cbb0 · 276cbb0
1 parent 61768c1
commit 276cbb0
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/open-bpmn.metamodel/src/main/java/org/openbpmn/bpmn/discovery/BPMNDiscovery.java b/open-bpmn.metamodel/src/main/java/org/openbpmn/bpmn/discovery/BPMNDiscovery.java
@@ -207,7 +207,6 @@ public BPMNDiscovery(List<String> startsEvent, List<String> endsEvent, LinkedLis
 	public void DependencyGraphToBPMN() throws BPMNModelException, CloneNotSupportedException {
 
 		BPMNProcess process = model.openDefaultProces();
-
 
 		// it is used for the sequence flow
 		for (String dependency : dependencies) {
@@ -1202,18 +1201,13 @@ private void loopBlockConstruction(List<BPMNElementNode> sourceElements, List<BP
 					+ sourceElements.stream().map(src -> src.getId()).collect(Collectors.toList()));
 			String tempActivity = "___temp___";
 			BPMNElementNode tempElement = process.addTask(tempActivity, tempActivity, BPMNTypes.TASK);
-			System.out.println(tempElement.getId());
 			for (String target : targetIds) {
 				BPMNElementNode targetElement = process.findElementNodeById(target);
 				System.out.println(targetElement.getId());
 				if (tempElement.getOutgoingSequenceFlows().size() > 0) {
 					addSplitGateway(tempElement, targetElement);
 					splitGateway = null;
-					// probably XOR join
-//					if (targetElement.getIngoingSequenceFlows().size() > 1) {
-//						addXorGateway(process, targetElement);
-//					}
-//					splitGateway = null;
+
 				} else {
 					process.addSequenceFlow("sq-" + seqenceFlowId.toString(), tempActivity, target);
 					seqenceFlowId++;
@@ -1224,8 +1218,15 @@ private void loopBlockConstruction(List<BPMNElementNode> sourceElements, List<BP
 				process.deleteSequenceFlow(sq.getId());
 			}
 			process.deleteElementNode(tempElement.getId());
+			for (String target : targetIds) {
+				BPMNElementNode targetElement = process.findElementNodeById(target);
+//			 probably XOR join
+				if (targetElement.getIngoingSequenceFlows().size() > 1) {
+					addXorGateway(process, targetElement);
+				}
+				splitGateway = null;
+			}
 
-//			}
 		}
 
 	}